linux-kernel - Re: [Patch v2 1/2] dmaengine: Add ADM driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54CB6F67.9080600@smartplayin.com>
Date:	Fri, 30 Jan 2015 17:17:51 +0530
From:	Pramod Gurav <pramod.gurav@...rtplayin.com>
To:	Andy Gross <agross@...eaurora.org>
CC:	Vinod Koul <vinod.koul@...el.com>, dmaengine@...r.kernel.org,
	Kumar Gala <galak@...eaurora.org>,
	linux-arm-kernel@...ts.infradead.org,
	linux-arm-msm@...r.kernel.org,
	Archit Taneja <architt@...eaurora.org>,
	Bjorn Andersson <bjorn.andersson@...ymobile.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [Patch v2 1/2] dmaengine: Add ADM driver

Hi Andy,
A minor doubt.

On Thursday 08 January 2015 08:56 AM, Andy Gross wrote:
> Signed-off-by: Andy Gross <agross@...eaurora.org>
> ---
>  drivers/dma/Kconfig    |   10 +
>  drivers/dma/Makefile   |    1 +
>  drivers/dma/qcom_adm.c |  899 ++++++++++++++++++++++++++++++++++++++++++++++++

<snip>

> +
> +	return ret;
> +}
> +
> +static struct dma_chan *adm_dma_xlate(struct of_phandle_args *dma_spec,
> +	struct of_dma *of)
> +{
> +	struct adm_device *adev = container_of(of->of_dma_data,
> +			struct adm_device, common);
> +	struct adm_chan *achan;
I don't see achan being used anywhere in this function? apart from below.
> +	struct dma_chan *chan;
> +	unsigned int request;
> +
> +	if (dma_spec->args_count != 1) {
> +		dev_err(adev->dev, "incorrect number of dma arguments\n");
> +		return NULL;
> +	}
> +
> +	request = dma_spec->args[0];
> +	if (request >= adev->num_channels)
> +		return NULL;
> +
> +	chan = dma_get_slave_channel(&(adev->channels[request].vc.chan));
> +
> +	if (!chan)
> +		return NULL;
> +
> +	achan = to_adm_chan(chan);
Could not understand the use of achan here. unused code?

> +
> +	return chan;
> +}
> +
> +/**
> + * adm_issue_pending - starts pending transactions
> + * @chan: dma channel

<snip>

> +module_platform_driver(adm_dma_driver);
> +
> +MODULE_AUTHOR("Andy Gross <agross@...eaurora.org>");
> +MODULE_DESCRIPTION("QCOM ADM DMA engine driver");
> +MODULE_LICENSE("GPL v2");
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/