linux-kernel - Re: [PATCH v2] staging: comedi: drivers: addi_apci_3501: Removed variables that is never used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54CB8424.4060407@mev.co.uk>
Date:	Fri, 30 Jan 2015 13:16:20 +0000
From:	Ian Abbott <abbotti@....co.uk>
To:	Dan Carpenter <dan.carpenter@...cle.com>
CC:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	H Hartley Sweeten <hsweeten@...ionengravers.com>,
	devel@...verdev.osuosl.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, Fred Akers <knivey@...ops.net>
Subject: Re: [PATCH v2] staging: comedi: drivers: addi_apci_3501: Removed
 variables that is never used

On 30/01/15 12:10, Dan Carpenter wrote:
> On Fri, Jan 30, 2015 at 10:29:44AM +0000, Ian Abbott wrote:
>>> @@ -285,7 +284,7 @@ static irqreturn_t apci3501_interrupt(int irq, void *d)
>>>   	ul_Command1 = inl(dev->iobase + APCI3501_TIMER_CTRL_REG);
>>>   	ul_Command1 = ((ul_Command1 & 0xFFFFF9FDul) | 1 << 1);
>>>   	outl(ul_Command1, dev->iobase + APCI3501_TIMER_CTRL_REG);
>>> -	i_temp = inl(dev->iobase + APCI3501_TIMER_STATUS_REG) & 0x1;
>>> +	inl(dev->iobase + APCI3501_TIMER_STATUS_REG);
>>>
>>>   	return IRQ_HANDLED;
>>>   }
>>>
>>
>> Reviewed-by: Ian Abbott <abbotti@....co.uk>
>
> Ian, is the inl() really needed?  Richard did the conservative thing,
> but if we knew we could delete the inl() that would be nice.

I'm not sure if it's really needed, but it is part of some watchdog 
functionality, so I thought it best to leave it alone.

Hartley might know if it's needed.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/