linux-kernel - Re: [PATCH 2/3] pinctrl: qcom: enable generic pinconf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYqGBigqfuYgBQTji2-tJR7avtgMxLQZAmMzP8zkp-0EA@mail.gmail.com>
Date:	Fri, 30 Jan 2015 14:39:01 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Stanimir Varbanov <svarbanov@...sol.com>
Cc:	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	Bjorn Andersson <bjorn.andersson@...ymobile.com>,
	Stephen Boyd <sboyd@...eaurora.org>
Subject: Re: [PATCH 2/3] pinctrl: qcom: enable generic pinconf

On Fri, Jan 30, 2015 at 11:27 AM, Stanimir Varbanov
<svarbanov@...sol.com> wrote:

> This makes the pinctrl driver to use the generic pinconf
> interface. Mainly it gives us a way to use debugfs to dump
> group configurations.
>
> Signed-off-by: Stanimir Varbanov <svarbanov@...sol.com>

Nice! Looking for Björn's review though.

> +++ b/drivers/pinctrl/qcom/pinctrl-msm.c
> @@ -197,7 +197,6 @@ static int msm_config_reg(struct msm_pinctrl *pctrl,
>                 *mask = 1;
>                 break;
>         default:
> -               dev_err(pctrl->dev, "Invalid config param %04x\n", param);
>                 return -ENOTSUPP;
>         }
>
> @@ -262,8 +261,6 @@ static int msm_config_group_get(struct pinctrl_dev *pctldev,
>                 arg = !!(val & BIT(g->in_bit));
>                 break;
>         default:
> -               dev_err(pctrl->dev, "Unsupported config parameter: %x\n",
> -                       param);
>                 return -EINVAL;

Please change this one to -ENOTSUPP as well in this patch.

Apart from that it looks good to me.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/