linux-kernel - Re: Question about ftrace, dynamically allocated trampolines and dynamic fops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150130091206.04216d1e@gandalf.local.home>
Date:	Fri, 30 Jan 2015 09:12:06 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Miroslav Benes <mbenes@...e.cz>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	jkosina@...e.cz
Subject: Re: Question about ftrace, dynamically allocated trampolines and
 dynamic fops

On Fri, 30 Jan 2015 11:08:19 +0100 (CET)
Miroslav Benes <mbenes@...e.cz> wrote:

> Anyway I think the problem is the opposite. There should be no 
> ftrace_ops_list_func for dynamic trampoline. See below, please...
> 


> 
> I think so. One thing is the code above. And verification in 
> next-20150130 in qemu, CONFIG_PREEMPT=n,...
> 
> I livepatched /proc/cmdline and there is no other tracing involved
> 
> dsc1:~ # cat /sys/kernel/debug/tracing/enabled_functions
> cmdline_proc_show (1) R I	tramp: 0xffffffffa0004000 ->ftrace_ops_list_func+0x0/0x1a0
> dsc1:~
> 
> I think that there should be direct call to the callback function (new 
> cmdline_proc_show). 
> 

Ah, OK I see the issue. Yeah, it shouldn't be that way. I'll have to
fix that.

Thanks,

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/