linux-kernel - Re: [PATCH v2 1/3] tools lib traceevent: add priv field to struct format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150130142447.GA19178@krava.brq.redhat.com>
Date:	Fri, 30 Jan 2015 15:24:47 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Wang Nan <wangnan0@...wei.com>, jeremie.galarneau@...icios.com,
	alexmonthy@...populi.im, bigeasy@...utronix.de, lizefan@...wei.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] tools lib traceevent: add priv field to struct
 format_field.

On Fri, Jan 30, 2015 at 09:17:19AM -0500, Steven Rostedt wrote:
> On Mon, 26 Jan 2015 18:38:23 +0800
> Wang Nan <wangnan0@...wei.com> wrote:
> 
> 
> > diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
> > index cf3a44b..5f76003 100644
> > --- a/tools/lib/traceevent/event-parse.c
> > +++ b/tools/lib/traceevent/event-parse.c
> > @@ -5909,6 +5909,8 @@ static void free_format_fields(struct format_field *field)
> >  		free(field->type);
> >  		free(field->name);
> >  		free(field);
> > +		if (field->destroy_priv)
> > +			field->destroy_priv(field);
> 
> I think you want to call field->destroy_priv() *before* you free field.

argh.. missed that :-\ will fix

thanks,
jirka

> 
> -- Steve
> 
> >  		field = next;
> >  	}
> >  }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/