linux-kernel - Re: [PATCH 2/4] NFC: nxp-nci: Add support for NXP NCI chips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150130001048.GD20998@ribalta.ger.corp.intel.com>
Date:	Fri, 30 Jan 2015 01:10:48 +0100
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	clement.perrochaud@...innov.com
Cc:	linux-nfc@...ts.01.org,
	Clément Perrochaud 
	<clement.perrochaud@....com>, sunil.jogi@....com,
	jerome.pele@....com, Charles.Gorand-Effinnov@....com,
	lauro.venancio@...nbossa.org, aloisio.almeida@...nbossa.org,
	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	davem@...emloft.net, grant.likely@...aro.org, lefrique@...vell.com,
	christophe.ricard@...il.com, cuissard@...vell.com,
	bzhao@...vell.com, hirent@...vell.com, akarwar@...vell.com,
	linux-wireless@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 2/4] NFC: nxp-nci: Add support for NXP NCI chips

Hi Clement,

On Thu, Jan 22, 2015 at 04:27:38PM +0100, clement.perrochaud@...innov.com wrote:
> @@ -686,7 +686,7 @@ L:	alsa-devel@...a-project.org (moderated for non-subscribers)
>  W:	http://blackfin.uclinux.org/
>  S:	Supported
>  F:	sound/soc/blackfin/*
> - 
> +
Unneeded change, please remove it.

> +config NFC_NXP_NCI
> +	tristate "NXP-NCI NFC driver"
> +	depends on NFC_NCI
> +	default n
> +	---help---
> +	  Generic core driver for NXP NCI chips.
It usually is nice to be more specific and describe which chipsets
(e.g. NPC100) this driver supports among all the NXP NCI chipsets.

> +struct nxp_nci_phy_ops {
> +	int (*enable)(void *id);
> +	int (*fw_enable)(void *id);
Wouldn't a int (*enable)(void *id, enum nxp_nci_mode mode); hook be
enough ?

Cheers,
Samuel.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/