linux-kernel - Re: [PATCH v2] staging: rtl8712: fix Prefer ether_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54CAE64D.2040703@lwfinger.net>
Date:	Thu, 29 Jan 2015 20:02:53 -0600
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Heba Aamer <heba93aamer@...il.com>, devel@...verdev.osuosl.org
CC:	florian.c.schilhabel@...glemail.com, gregkh@...uxfoundation.org,
	tapaswenipathak@...il.com, thomas@...uk.net,
	sudipm.mukherjee@...il.com, rickard_strandqvist@...ctrumdigital.se,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: rtl8712: fix Prefer ether_addr_copy() over
 memcpy()

On 01/29/2015 04:11 PM, Heba Aamer wrote:
> This patch fixes the following checkpatch.pl warning:
> Prefer ether_addr_copy() over memcpy()
> if the Ethernet addresses are __aligned(2)
>
> pahole showed that the struct used pnetdev->dev_addr
> is aligned to u16.
>
> Moreover mac is a simple array, pdata is a pointer that
> starts from an even offset.
>
> Signed-off-by: Heba Aamer <heba93aamer@...il.com>
> ---
> v2: modifying patch description
>
>   drivers/staging/rtl8712/usb_intf.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

This is much better.

Acked-by: Larry Finger <Larry.Finger@...inger.net>

Larry

>
> diff --git a/drivers/staging/rtl8712/usb_intf.c b/drivers/staging/rtl8712/usb_intf.c
> index 15f0d42..a2f2dfb 100644
> --- a/drivers/staging/rtl8712/usb_intf.c
> +++ b/drivers/staging/rtl8712/usb_intf.c
> @@ -463,7 +463,7 @@ static int r871xu_drv_init(struct usb_interface *pusb_intf,
>   				/* Use the mac address stored in the Efuse
>   				 * offset = 0x12 for usb in efuse
>   				 */
> -				memcpy(mac, &pdata[0x12], ETH_ALEN);
> +				ether_addr_copy(mac, &pdata[0x12]);
>   			}
>   			eeprom_CustomerID = pdata[0x52];
>   			switch (eeprom_CustomerID) {
> @@ -580,7 +580,7 @@ static int r871xu_drv_init(struct usb_interface *pusb_intf,
>   		} else
>   			dev_info(&udev->dev,
>   				"r8712u: MAC Address from efuse = %pM\n", mac);
> -		memcpy(pnetdev->dev_addr, mac, ETH_ALEN);
> +		ether_addr_copy(pnetdev->dev_addr, mac);
>   	}
>   	/* step 6. Load the firmware asynchronously */
>   	if (rtl871x_load_fw(padapter))
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/