linux-kernel - Re: [PATCH] efi, x86: Add a "debug" option to the efi= cmdline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54CBB820.3090008@redhat.com>
Date:	Fri, 30 Jan 2015 17:58:08 +0100
From:	Laszlo Ersek <lersek@...hat.com>
To:	Borislav Petkov <bp@...en8.de>,
	Matt Fleming <matt@...sole-pimps.org>
CC:	Jon Masters <jonathan@...masters.org>,
	Dave Young <dyoung@...hat.com>,
	linux-efi <linux-efi@...r.kernel.org>,
	Ard Biesheuvel <ard.biesheuvel@...aro.org>,
	Matt Fleming <matt.fleming@...el.com>,
	Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] efi, x86: Add a "debug" option to the efi= cmdline

On 01/30/15 17:43, Borislav Petkov wrote:
> From: Borislav Petkov <bp@...e.de>
> Date: Mon, 26 Jan 2015 19:49:59 +0100
> Subject: [PATCH] efi, x86: Add a "debug" option to the efi= cmdline
> 
> ... and hide the memory regions dump behind it. Make it default-off.
> 
> Signed-off-by: Borislav Petkov <bp@...e.de>
> Link: http://lkml.kernel.org/r/20141209095843.GA3990@pd.tnic
> ---
>  arch/x86/platform/efi/efi.c | 5 ++++-
>  include/linux/efi.h         | 1 +
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
> index dbc8627a5cdf..e859d56ce9f8 100644
> --- a/arch/x86/platform/efi/efi.c
> +++ b/arch/x86/platform/efi/efi.c
> @@ -491,7 +491,8 @@ void __init efi_init(void)
>  	if (efi_memmap_init())
>  		return;
>  
> -	print_efi_memmap();
> +	if (efi_enabled(EFI_DBG))
> +		print_efi_memmap();
>  }
>  
>  void __init efi_late_init(void)
> @@ -939,6 +940,8 @@ static int __init arch_parse_efi_cmdline(char *str)
>  {
>  	if (parse_option_str(str, "old_map"))
>  		set_bit(EFI_OLD_MEMMAP, &efi.flags);
> +	if (parse_option_str(str, "debug"))
> +		set_bit(EFI_DBG, &efi.flags);
>  
>  	return 0;
>  }
> diff --git a/include/linux/efi.h b/include/linux/efi.h
> index 0238d612750e..14cec75d7e74 100644
> --- a/include/linux/efi.h
> +++ b/include/linux/efi.h
> @@ -940,6 +940,7 @@ extern int __init efi_setup_pcdp_console(char *);
>  #define EFI_64BIT		5	/* Is the firmware 64-bit? */
>  #define EFI_PARAVIRT		6	/* Access is via a paravirt interface */
>  #define EFI_ARCH_1		7	/* First arch-specific bit */
> +#define EFI_DBG			8	/* Print additional debug info at runtime */
>  
>  #ifdef CONFIG_EFI
>  /*
> 

I don't know much about the efi flag setting, but it look sane to me.

ACK

Laszlo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/