linux-kernel - Re: [PATCH] x86, mce: Always fall into mcelog path, regardless of what notifiers returned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150130173830.GB1893@pd.tnic>
Date:	Fri, 30 Jan 2015 18:38:30 +0100
From:	Borislav Petkov <bp@...e.de>
To:	Tony Luck <tony.luck@...el.com>
Cc:	linux-kernel@...r.kernel.org, linux-edac@...r.kernel.org,
	Chen Gong <gong.chen@...ux.intel.com>
Subject: Re: [PATCH] x86, mce: Always fall into mcelog path, regardless of
 what notifiers returned

On Fri, Jan 30, 2015 at 09:29:47AM -0800, Tony Luck wrote:
> This has been broken for a while - but we should not allow code
> registered on the x86_mce_decoder_chain to bypass sending machine
> check logs to /dev/mcelog.
> 
> Signed-off-by: Tony Luck <tony.luck@...el.com>
> ---
> 
> Yes, we've had this conversation before and I wimped out and didn't
> push the issue. But userspace is broken. People are complaining to
> me that errors don't show up in /var/log/mcelog even though they
> started the mcelog(8) daemon.

We need to fix this differently - on AMD, mcelog is not needed as the
decoding is done in the kernel.

We could use mce_register_decode_chain() for callers to state what they
want.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/