linux-kernel - Re: [PATCH] ARM: /proc/cpuinfo: DT: Add support for Revision

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqLvj3zW9v+R3y8uOi8ZCPj5Q+NT057j-8URHavDeWqUAQ@mail.gmail.com>
Date:	Fri, 30 Jan 2015 15:03:36 -0600
From:	Rob Herring <robherring2@...il.com>
To:	Pali Rohár <pali.rohar@...il.com>
Cc:	Russell King <linux@....linux.org.uk>,
	Will Deacon <will.deacon@....com>,
	Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>,
	Sebastian Reichel <sre@...ian.org>,
	Pavel Machek <pavel@....cz>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Tony Lindgren <tony@...mide.com>
Subject: Re: [PATCH] ARM: /proc/cpuinfo: DT: Add support for Revision

lOn Fri, Jan 30, 2015 at 8:14 AM, Pali Rohár <pali.rohar@...il.com> wrote:
> On Monday 26 January 2015 21:22:27 Rob Herring wrote:
>> On Mon, Jan 26, 2015 at 1:09 PM, Pali Rohár
> <pali.rohar@...il.com> wrote:
>> > Ok, here is patch which set Revision field (global variable
>> > system_rev) in /proc/cpuinfo from DT revision property:

[...]

>> > I do not know which DT property to use for storing HW
>> > Revision, so if "/revision" is not correct one, let me know
>> > what to use instead. Also you can add my Signed-off-by for
>> > both patches.
>>
>> It is the correct property, but /revision in DT is a string.
>>
>> You need to add your own sign-off.
>>
>> Rob
>
> Any documentation which says that /revision is string?

Sorry, I was confusing this with serial-number, so I guess a number is
fine here.

> If it is really string, how to store ATAG_REVISON (number) to
> string? dec or hex?

However /proc/cpuinfo displays it would be fine if you stay with a string.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/