linux-kernel - Re: [GIT PULL] PCI fixes for v3.19

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE9FiQWM0teGrWjn2xTfbLW1hqYG0Xau8poSxJCWfjfaQhdt5Q@mail.gmail.com>
Date:	Fri, 30 Jan 2015 13:49:54 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	Bjorn Helgaas <bhelgaas@...gle.com>
Cc:	Tony Luck <tony.luck@...il.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Lucas Stach <l.stach@...gutronix.de>,
	Richard Zhu <Richard.Zhu@...escale.com>,
	Marek Kordik <kordikmarek@...il.com>,
	Alex Williamson <alex.williamson@...hat.com>,
	Andreas Hartmann <andihartmann@...enet.de>,
	Alexey Voronkov <zermond@...il.com>,
	David Airlie <airlied@...ux.ie>,
	Alex Deucher <alexander.deucher@....com>
Subject: Re: [GIT PULL] PCI fixes for v3.19

On Fri, Jan 30, 2015 at 8:56 AM, Bjorn Helgaas <bhelgaas@...gle.com> wrote:
> On Tue, Jan 27, 2015 at 6:54 PM, Yinghai Lu <yinghai@...nel.org> wrote:
>> On Tue, Jan 27, 2015 at 3:24 PM, Tony Luck <tony.luck@...il.com> wrote:
>>> On Mon, Jan 26, 2015 at 7:43 PM, Yinghai Lu <yinghai@...nel.org> wrote:
>>>> Can you please get boot bog with "debug ignore_logleve"?
>>>>
>>>> we should get print out from
>>>>
>>>> +               dev_printk(KERN_DEBUG, &dev->dev, "%pR clipped to %pR\n",
>>>> +                                &orig_res, res);
>>>
>>> Attached ... but I don't see any "clipped" messages
>>
>> Good. so the system should just work as before but have annoying warnings.
>>
>> Do we need to put the paper back to hide the warning?
>
> Ping, I'm not sure this is resolved.
>
> Tony, does the system work as it did before?  Is the only problem that
> now we have more warnings than we did before?
>
> Yinghai, I sort of feel like I'm being left to sweep up behind your
> changes here.  I *could* analyze this and figure out what's going on
> and fix it, but I don't have time to do that for everybody, and I
> consider that more your job.

Sorry to hear that.

I did respond the email, and gave the the explanation.

>
> If we start with the same _CRS config and same device config, ideally
> PCI enumeration would produce the same messages, same warnings, and
> same resource assignments no matter what arch we feed them to, because
> enumeration is not really arch-specific.  So if ia64 does something
> different here, I think something needs to be fixed.

ia64 was doing different,
1. It check if the range is valid with bus resources. and only call
pci_claim_resource for that path.
2. and it does not reset invalid resource to allocate new one.

This patch change to call pci_claim_resource directly, so we have warning now.
but just warning as we did not reset the resource.

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/