linux-kernel - Re: [PATCH v2 2/4] gpio: add parameter to allow the use named gpios

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150130222204.GA23203@dtor-ws>
Date:	Fri, 30 Jan 2015 14:22:04 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Bryan Wu <cooloney@...il.com>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Olliver Schinagl <o.schinagl@...imaker.com>,
	Alexandre Courbot <gnurou@...il.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Richard Purdie <rpurdie@...ys.net>,
	Olliver Schinagl <oliver@...inagl.nl>,
	Robin Gong <b38343@...escale.com>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Aaron Lu <aaron.lu@...el.com>,
	Grant Likely <grant.likely@...aro.org>,
	Jingoo Han <jg1.han@...sung.com>,
	Alexander Shiyan <shc_work@...l.ru>,
	Wolfram Sang <wsa@...-dreams.de>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	Linux Input <linux-input@...r.kernel.org>,
	"linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>
Subject: Re: [PATCH v2 2/4] gpio: add parameter to allow the use named gpios

On Fri, Jan 30, 2015 at 02:16:00PM -0800, Dmitry Torokhov wrote:
> On Fri, Jan 30, 2015 at 11:12:53AM -0800, Bryan Wu wrote:
> > On Fri, Jan 30, 2015 at 5:46 AM, Linus Walleij <linus.walleij@...aro.org> wrote:
> > > On Wed, Jan 21, 2015 at 10:33 PM, Olliver Schinagl
> > > <o.schinagl@...imaker.com> wrote:
> > >
> > >> From: Olliver Schinagl <oliver@...inagl.nl>
> > >>
> > >> The gpio binding document says that new code should always use named
> > >> gpios. Patch 40b73183 added support to parse a list of gpios from child
> > >> nodes, but does not make it possible to use named gpios. This patch adds
> > >> the con_id property and implements it is done in gpiolib.c, where the
> > >> old-style of using unnamed gpios still works.
> > >>
> > >> Signed-off-by: Olliver Schinagl <oliver@...inagl.nl>
> > >> ---
> > >>  drivers/gpio/devres.c                     | 18 +++++++++++++++++-
> > >>  drivers/input/keyboard/gpio_keys_polled.c |  2 +-
> > >>  drivers/leds/leds-gpio.c                  |  2 +-
> > >>  include/linux/gpio/consumer.h             |  1 +
> > >
> > > Alexandre: does this match your vision of how it should work, i.e. ACK?
> > >
> > > Bryan/Dmitry: can you ACK the oneliners in your subsystems?
> > 
> > Sure, please take my Ack
> > Acked-by: Bryan Wu <cooloney@...il.com>
> 
> Mine as well:
> 
> Acked-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

Forgot to mention: the ack is for this patch only; the patch #4 is
NAKed because:

1. The logic of handling old and new name AFAICS is broken and
2. gpio_keys_polled-gpios as name is plain ugly.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/