| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <54CC185E.9010007@codeaurora.org> Date: Fri, 30 Jan 2015 15:48:46 -0800 From: Stephen Boyd <sboyd@...eaurora.org> To: Michael Turquette <mturquette@...aro.org>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 3/3] clk: remove clk-private.h On 01/30/15 13:25, Michael Turquette wrote: > Private clock framework data structures should be private, surprisingly. > > Now that all platforms and drivers have been updated to remove static > initializations of struct clk and struct clk_core objects and all > references to clk-private.h have been removed we can move the > definitions of these structures into drivers/clk/clk.c and delete the > header. > > Additionally the ugly DEFINE_CLK macros have been removed. Those were > used for static definitions of struct clk objects. That practice is no > longer allowed. > > Signed-off-by: Michael Turquette <mturquette@...aro.org> This is great! Reviewed-by: Stephen Boyd <sboyd@...eaurora.org> given the minor comment below. > - * Returns 0 on success, otherwise an error code. > - */ > -int __clk_init(struct device *dev, struct clk *clk); Shouldn't __clk_init become static now in clk.c? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists