[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <F792CF86EFE20D4AB8064279AFBA51C61EA9B94D@SIXPRD3002MB028.064d.mgd.msft.net>
Date: Fri, 30 Jan 2015 04:26:44 +0000
From: Dexuan Cui <decui@...rosoft.com>
To: Vitaly Kuznetsov <vkuznets@...hat.com>
CC: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"driverdev-devel@...uxdriverproject.org"
<driverdev-devel@...uxdriverproject.org>,
"olaf@...fle.de" <olaf@...fle.de>,
"apw@...onical.com" <apw@...onical.com>,
"jasowang@...hat.com" <jasowang@...hat.com>,
KY Srinivasan <kys@...rosoft.com>,
Haiyang Zhang <haiyangz@...rosoft.com>
Subject: RE: [PATCH 1/3] hv: hv_util: move vmbus_open() to a later place
> -----Original Message-----
> From: Vitaly Kuznetsov [mailto:vkuznets@...hat.com]
> Sent: Thursday, January 29, 2015 21:13 PM
> To: Dexuan Cui
> Cc: gregkh@...uxfoundation.org; linux-kernel@...r.kernel.org; driverdev-
> devel@...uxdriverproject.org; olaf@...fle.de; apw@...onical.com;
> jasowang@...hat.com; KY Srinivasan; Haiyang Zhang
> Subject: Re: [PATCH 1/3] hv: hv_util: move vmbus_open() to a later place
>
> Dexuan Cui <decui@...rosoft.com> writes:
>
> > Before the line vmbus_open() returns, srv->util_cb can be already running
> > and the variablies, like util_fw_version, are needed by the srv->util_cb.
> >
> > So we have to make sure the variables are initialized before the vmbus_open().
> >
> > CC: "K. Y. Srinivasan" <kys@...rosoft.com>
> > Signed-off-by: Dexuan Cui <decui@...rosoft.com>
>
> It is not said in the description but moving hv_set_drvdata() before
> vmbus_open() make sense in case probe and remove can collide (can
> they?).
I'm not so sure. In normal usages, the collision should be unlikely.
Anyway, the patch makes things better. :-)
>
> Reviewed-by: Vitaly Kuznetsov <vkuznets@...hat.com>
Thanks for the review!
Thanks,
-- Dexuan
> > ---
> > drivers/hv/hv_util.c | 11 ++++++-----
> > 1 file changed, 6 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/hv/hv_util.c b/drivers/hv/hv_util.c
> > index 3b9c9ef..c5be773 100644
> > --- a/drivers/hv/hv_util.c
> > +++ b/drivers/hv/hv_util.c
> > @@ -340,12 +340,8 @@ static int util_probe(struct hv_device *dev,
> >
> > set_channel_read_state(dev->channel, false);
> >
> > - ret = vmbus_open(dev->channel, 4 * PAGE_SIZE, 4 * PAGE_SIZE, NULL, 0,
> > - srv->util_cb, dev->channel);
> > - if (ret)
> > - goto error;
> > -
> > hv_set_drvdata(dev, srv);
> > +
> > /*
> > * Based on the host; initialize the framework and
> > * service version numbers we will negotiate.
> > @@ -365,6 +361,11 @@ static int util_probe(struct hv_device *dev,
> > hb_srv_version = HB_VERSION;
> > }
> >
> > + ret = vmbus_open(dev->channel, 4 * PAGE_SIZE, 4 * PAGE_SIZE, NULL, 0,
> > + srv->util_cb, dev->channel);
> > + if (ret)
> > + goto error;
> > +
> > return 0;
> >
> > error:
>
> --
> Vitaly
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists