linux-kernel - Re: [PATCH] ata: libahci: Use of_platform_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 31 Jan 2015 12:08:12 -0500
From:	Tejun Heo <tj@...nel.org>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	Hans de Goede <hdegoede@...hat.com>, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Gregory CLEMENT <gregory.clement@...e-electrons.com>
Subject: Re: [PATCH] ata: libahci: Use of_platform_device_create only if
 supported

On Sat, Jan 31, 2015 at 08:53:36AM -0800, Guenter Roeck wrote:
> I agree, it is weird, as is the whole "all API functions associated
> with OF_ADDRESS are handled differently on sparc" thing. But that
> is neither new nor something I can fix.

Out of curiousity, why isn't the header file doing the following?

#ifdef CONFIG_OF_ADDRESS

void of_platform_device_create(blah);
...

#else

static inline void of_platform_device_create(blah)
{
}

#endif

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/