linux-kernel - Re: [PATCH] pci-dma: Fix x86 dma_alloc_coherent to fully clear all pages returned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1501311210001.28306-100000@netrider.rowland.org>
Date:	Sat, 31 Jan 2015 12:14:29 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Andi Kleen <andi@...stfloor.org>
cc:	Greg KH <gregkh@...uxfoundation.org>,
	Tim Chen <tim.c.chen@...ux.intel.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Akinobu Mita <akinobu.mita@...il.com>,
	Mathias Nyman <mathias.nyman@...ux.intel.com>,
	Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	<linux-kernel@...r.kernel.org>, <x86@...nel.org>,
	<linux-usb@...r.kernel.org>
Subject: Re: [PATCH] pci-dma: Fix x86 dma_alloc_coherent to fully clear all
 pages returned

On Fri, 30 Jan 2015, Andi Kleen wrote:

> > We don't "need" any backward compatility, why not fix the broken drivers
> > that are using memory outside of what they are asking for?  That's not
> > ok no matter what, right?
> 
> How would you find them all?
> 
> We don't even know which place in XHCI is the culprit here.

It shouldn't be too hard to find, expecially if the fault can easily 
be reproduced.

There are only about half a dozen calls to dma_alloc_coherent in the
xhci-hcd driver.  Just add 64 KB to the requested memory size in each
of them.  Then one-by-one (or using bisection) remove the extra size
and see which spots trigger the fault.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/