linux-kernel - Re: [PATCH] staging: rtl8188eu: core: rtw_sta_mgt: Removed variables that is never used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54CD13B0.9030009@lwfinger.net>
Date:	Sat, 31 Jan 2015 11:41:04 -0600
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Dan Carpenter <dan.carpenter@...cle.com>,
	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:	devel@...verdev.osuosl.org, Jia He <hejianet@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8188eu: core: rtw_sta_mgt: Removed variables
 that is never used

On 01/31/2015 10:19 AM, Dan Carpenter wrote:
> On Sat, Jan 31, 2015 at 03:45:33PM +0100, Rickard Strandqvist wrote:
>>   	while (phead != plist) {
>> -		psta = container_of(plist, struct sta_info , list);
>> +		container_of(plist, struct sta_info, list);
>
>
> Argh!!!  No.
>
> For this one, I didn't need an context to see that it was wrong, so I
> accidentally reviewed it instead of just marking it as read.
>

Dan,

This guy does not have a brain - he only knows how to run cppcheck. You cannot 
expect him to think about what he does. In addition, he does not have any of the 
hardware that uses the drivers he is mangling. He can only test that it builds 
correctly. Do not bother to ever review anything he sends.

Earlier this month, he submitted a set of patches that impacted routines that I 
was working on. I asked him to hold those until I was finished to avoid 
conflicts. Guess what? The same set was resubmitted 4 days later!!

He was told that sets of patches were supposed to be submitted with a [PATCH 
X/Y] structure, but he has ignored that suggestion, thus there is no way to send 
an overall NACK.

@Greg: Please put this guy on your permanent blacklist. It takes too much time 
to read and respond to his multiple posts. Kalle has already done that for wireless.

Larry

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/