linux-kernel - Re: [PATCH] drivers: mmc: card: Fixing few coding style errors from file block.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 31 Jan 2015 10:44:50 -0800
From:	Joe Perches <joe@...ches.com>
To:	Sheetal Tigadoli <sheetal.tigadoli@...il.com>
Cc:	chris@...ntf.net, linux-mmc@...r.kernel.org, ben@...adent.org.uk,
	kuninori.morimoto.gx@...esas.com, ulf.hansson@...aro.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: mmc: card: Fixing few coding style errors from
 file block.c

On Sat, 2015-01-31 at 23:37 +0530, Sheetal Tigadoli wrote:
> The patch fixes some of the following error/warnings from the file block.c
> 
> ./scripts/checkpatch.pl  --file --terse drivers/mmc/card/block.c

Hi.

It's a lot easier to review and accept these sorts of
changes if you break them into more discrete patches.

Try bundling all the similar types of changes into
single patches, each doing more or less the same thing.

Something like:

1: line length conversions
   btw: Please use checkpatch --strict to make sure that
	multi-line statements are aligned appropriately
2: adding removing blank lines and braces position/removals
3: strto -> kstrto conversions
4: else not necessary
5: coalescing split strings
6: include path conversions

Also please use a cover letter when submitting multiple patches.
It makes it easier to ack and apply the whole set.

> drivers/mmc/card/block.c:45: WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
> drivers/mmc/card/block.c:102: WARNING: line over 80 characters
> drivers/mmc/card/block.c:186: WARNING: Missing a blank line after declarations
> drivers/mmc/card/block.c:238: WARNING: line over 80 characters
> drivers/mmc/card/block.c:251: WARNING: line over 80 characters
> drivers/mmc/card/block.c:279: WARNING: simple_strtoul is obsolete, use kstrtoul instead
> drivers/mmc/card/block.c:280: WARNING: Missing a blank line after declarations
> drivers/mmc/card/block.c:578: WARNING: line over 80 characters
> drivers/mmc/card/block.c:586: WARNING: line over 80 characters
> drivers/mmc/card/block.c:620: WARNING: Missing a blank line after declarations
> drivers/mmc/card/block.c:1209: WARNING: line over 80 characters
> drivers/mmc/card/block.c:1333: WARNING: quoted string split across lines
> drivers/mmc/card/block.c:1720: WARNING: Missing a blank line after declarations
> drivers/mmc/card/block.c:1734: WARNING: braces {} are not necessary for single statement blocks
> drivers/mmc/card/block.c:1881: WARNING: else is not generally useful after a break or return
> drivers/mmc/card/block.c:2019: WARNING: braces {} are not necessary for single statement blocks
> drivers/mmc/card/block.c:2226: WARNING: line over 80 characters
> drivers/mmc/card/block.c:2285: WARNING: line over 80 characters
> drivers/mmc/card/block.c:2362: ERROR: that open brace { should be on the previous line


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/