linux-kernel - Re: [PATCH] Warning that occured while compiling the nvec in 3.19.0-rc5+ is fixed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 31 Jan 2015 20:11:29 +0100
From:	Julian Andres Klode <jak@...-linux.org>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	varsharamt <varsharamt91@...il.com>, marvin24@....de,
	ac100@...ts.launchpad.net, linux-tegra@...r.kernel.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Warning that occured while compiling the nvec in
 3.19.0-rc5+ is fixed

On 31 January 2015 at 17:29, Greg KH <gregkh@...uxfoundation.org> wrote:
> On Sat, Jan 31, 2015 at 05:24:42PM +0530, varsharamt wrote:
>> The task was to fix  a warning which was shown while compiling a driver
>> called NVEC. I wrote a brief description about how to enable support for
>> a nVidya complaint embedded controller.
>
> This makes no sense, what "task"?
>
>> Signed-off-by:Varsha Ram T<varsharamt91@...il.com>
>
> Please use proper spaces.
>
> Also, this doesn't match your From: line.  And, is this the name you use
> to sign legal documents?
>
>
>> ---
>>  drivers/staging/nvec/Kconfig | 20 ++++++++++----------
>>  1 file changed, 10 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/staging/nvec/Kconfig b/drivers/staging/nvec/Kconfig
>> index 9475e20..a65ad4c 100644
>> --- a/drivers/staging/nvec/Kconfig
>> +++ b/drivers/staging/nvec/Kconfig
>> @@ -3,33 +3,33 @@ config MFD_NVEC
>>       depends on I2C && GPIOLIB && ARCH_TEGRA
>>       select MFD_CORE
>>       help
>> -         Say Y here to enable support for a nVidia compliant embedded
>> -         controller.
>> +     Say Y to enable support for a nVidia complaint embedded controller.
>> +     nVidia complaint embedded controller is used to communicate with EC.
>> +     This is done through I2C bus.
>> +     The request to the EC can be initiated by triggering a gpio line.
>> +     The gpio line is a generic pin on integrated circuit whose input or output pin can be controlled by the user at run time.
>
>
> There's no way this is correct, look at how long your line is.
>

I'm not even sure if this level of detail is needed. Why should anyone
that reads the config option care how NVEC is enabled or communicated
with?

-- 
Julian Andres Klode  - Debian Developer, Ubuntu Member

See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/