Message-ID: <20150131192826.GD17425@developer.hsd1.ca.comcast.net>
Date:	Sat, 31 Jan 2015 15:28:27 -0400
From:	Eduardo Valentin <edubezval@...il.com>
To:	Paul Walmsley <paul@...an.com>
Cc:	devicetree@...r.kernel.org, Mark Rutland <mark.rutland@....com>,
	Wolfram Sang <wsa@...-dreams.de>, Takashi Iwai <tiwai@...e.de>,
	linux-pci@...r.kernel.org,
	Linus Walleij <linus.walleij@...aro.org>,
	dri-devel@...ts.freedesktop.org,
	Mikko Perttunen <mperttunen@...dia.com>,
	Thierry Reding <thierry.reding@...il.com>,
	linux-i2c@...r.kernel.org, Paul Walmsley <pwalmsley@...dia.com>,
	linux-pm@...r.kernel.org, Alexandre Courbot <gnurou@...il.com>,
	Terje Bergström <tbergstrom@...dia.com>,
	Stephen Warren <swarren@...dotorg.org>,
	Murali Karicheri <m-karicheri2@...com>,
	Dylan Reid <dgreid@...omium.org>, linux-pwm@...r.kernel.org,
	Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Jingchang Lu <jingchang.lu@...escale.com>,
	Hans de Goede <hdegoede@...hat.com>,
	Rob Herring <robh+dt@...nel.org>,
	Sean Paul <seanpaul@...omium.org>, linux-tegra@...r.kernel.org,
	Zhang Rui <rui.zhang@...el.com>,
	John Crispin <blogic@...nwrt.org>,
	Peter Hurley <peter@...leysoftware.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Peter De Schrijver <pdeschrijver@...dia.com>,
	linux-kernel@...r.kernel.org,
	Tuomas Tynkkynen <ttynkkynen@...dia.com>,
	Kumar Gala <galak@...eaurora.org>, Tejun Heo <tj@...nel.org>
Subject: Re: [PATCH v2 2/3] Documentation: DT bindings: add more Tegra chip
 compatible strings

Hey Paul!

On Fri, Jan 30, 2015 at 03:11:04PM -0700, Paul Walmsley wrote:
> Align compatible strings for several IP blocks present on Tegra chips
> with the latest doctrine from the DT maintainers:
> 
> http://marc.info/?l=devicetree&m=142255654213019&w=2
> 
> The primary objective here is to avoid checkpatch warnings, per:
> 
> http://marc.info/?l=linux-tegra&m=142201349727836&w=2
> 
> DT binding text files have been updated for the following IP blocks:
> 
> - PCIe
> - SOR
> - SoC timers
> - AHB "gizmo"
> - APB_MISC
> - pinmux control
> - UART
> - PWM
> - I2C
> - SPI
> - RTC
> - PMC
> - eFuse
> - AHCI
> - HDA
> - XUSB_PADCTRL
> - SDHCI
> - SOC_THERM
> - AHUB
> - I2S
> - EHCI
> - USB PHY
> 
> N.B. The nvidia,tegra20-timer compatible string is removed from the
> nvidia,tegra30-timer.txt documentation file because it's already
> mentioned in the nvidia,tegra20-timer.txt documentation file.
> 
> This second version takes into account the following requests from
> Rob Herring <robherring2@...il.com>:
> 
> - Per-IP block patches have been combined into a single patch
> 
> - Explicit documentation about which compatible strings are actually
>   matched by the driver has been removed.  In its place is implicit
>   documentation that loosely follows Rob's prescribed format:
> 
>   "Must contain '"nvidia,<chip>-pcie", "nvidia,tegra20-pcie"' where
>    <chip> is tegra30, tegra132, ..." [...]  "You should attempt to
>    document known values of <chip> if you use it"
> 
> 
> Signed-off-by: Paul Walmsley <paul@...an.com>
> Cc: Alexandre Courbot <gnurou@...il.com>
> Cc: Dylan Reid <dgreid@...omium.org>
> Cc: Eduardo Valentin <edubezval@...il.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Hans de Goede <hdegoede@...hat.com>
> Cc: Ian Campbell <ijc+devicetree@...lion.org.uk>
> Cc: Jingchang Lu <jingchang.lu@...escale.com>
> Cc: John Crispin <blogic@...nwrt.org>
> Cc: Kumar Gala <galak@...eaurora.org>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Mark Rutland <mark.rutland@....com>
> Cc: Mikko Perttunen <mperttunen@...dia.com>
> Cc: Murali Karicheri <m-karicheri2@...com>
> Cc: Paul Walmsley <pwalmsley@...dia.com>
> Cc: Pawel Moll <pawel.moll@....com>
> Cc: Peter De Schrijver <pdeschrijver@...dia.com>
> Cc: Peter Hurley <peter@...leysoftware.com>
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: Sean Paul <seanpaul@...omium.org>
> Cc: Stephen Warren <swarren@...dotorg.org>
> Cc: Takashi Iwai <tiwai@...e.de>
> Cc: Tejun Heo <tj@...nel.org>
> Cc: "Terje Bergström" <tbergstrom@...dia.com>
> Cc: Thierry Reding <thierry.reding@...il.com>
> Cc: Tuomas Tynkkynen <ttynkkynen@...dia.com>
> Cc: Wolfram Sang <wsa@...-dreams.de>
> Cc: Zhang Rui <rui.zhang@...el.com>
> Cc: dri-devel@...ts.freedesktop.org
> Cc: linux-i2c@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Cc: linux-pci@...r.kernel.org
> Cc: linux-pm@...r.kernel.org
> Cc: linux-pwm@...r.kernel.org
> Cc: linux-tegra@...r.kernel.org
> ---
>  .../bindings/arm/tegra/nvidia,tegra20-ahb.txt      |    5 ++++-
>  .../bindings/arm/tegra/nvidia,tegra20-pmc.txt      |    6 +++++-
>  .../devicetree/bindings/ata/tegra-sata.txt         |    4 +++-
>  .../bindings/fuse/nvidia,tegra20-fuse.txt          |   10 +++++-----
>  .../bindings/gpu/nvidia,tegra20-host1x.txt         |    8 ++++++--
>  .../devicetree/bindings/i2c/nvidia,tegra20-i2c.txt |   10 +++++-----
>  .../bindings/misc/nvidia,tegra20-apbmisc.txt       |    9 ++++-----
>  .../bindings/mmc/nvidia,tegra20-sdhci.txt          |    6 +++++-
>  .../bindings/pci/nvidia,tegra20-pcie.txt           |    8 ++++----
>  .../bindings/pinctrl/nvidia,tegra124-pinmux.txt    |    3 ++-
>  .../pinctrl/nvidia,tegra124-xusb-padctl.txt        |    4 +++-
>  .../devicetree/bindings/pwm/nvidia,tegra20-pwm.txt |    7 ++++---
>  .../devicetree/bindings/rtc/nvidia,tegra20-rtc.txt |    4 +++-
>  .../devicetree/bindings/serial/of-serial.txt       |    5 ++++-
>  .../bindings/sound/nvidia,tegra30-ahub.txt         |    5 ++++-
>  .../bindings/sound/nvidia,tegra30-hda.txt          |    4 +++-
>  .../bindings/sound/nvidia,tegra30-i2s.txt          |    5 ++++-
>  .../bindings/spi/nvidia,tegra114-spi.txt           |    4 +++-
>  .../devicetree/bindings/thermal/tegra-soctherm.txt |    4 +++-

<cut>

> diff --git a/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt b/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
> index ecf3ed76cd46..6b68cd150405 100644
> --- a/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
> +++ b/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
> @@ -7,7 +7,9 @@ notifications. It is also used to manage emergency shutdown in an
>  overheating situation.
>  
>  Required properties :
> -- compatible : "nvidia,tegra124-soctherm".
> +- compatible : For Tegra124, must contain "nvidia,tegra124-soctherm".
> +  For Tegra132, must contain "nvidia,tegra132-soctherm".
> +  For Tegra210, must contain "nvidia,tegra210-soctherm".
>  - reg : Should contain 1 entry:
>    - SOCTHERM register set
>  - interrupts : Defines the interrupt used by SOCTHERM

Considering that this is going into a single patch, you may add my

Acked-by: Eduardo Valentin <edubezval@...il.com>

for what concerns the thermal bindings.

Cheers,

Eduardo Valentin

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)

Powered by blists - more mailing lists