linux-kernel - Re: [PATCH] staging: vt6655: dpc: Removed variables that is never used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54CD537E.9000906@gmail.com>
Date:	Sat, 31 Jan 2015 22:13:18 +0000
From:	Malcolm Priestley <tvboxspy@...il.com>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	Forest Bond <forest@...ttletooquiet.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:	Guido Martínez <guido@...guardiasur.com.ar>,
	Guillaume Clement <gclement@...bob.org>,
	Veronika Kabatova <veronicca114@...il.com>,
	Joe Perches <joe@...ches.com>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: vt6655: dpc: Removed variables that is never
 used



On 31/01/15 15:16, Rickard Strandqvist wrote:
> Variable was assigned a value that was never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> ---
>   drivers/staging/vt6655/dpc.c |    4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/vt6655/dpc.c b/drivers/staging/vt6655/dpc.c
> index 977683c..9e9da3c 100644
> --- a/drivers/staging/vt6655/dpc.c
> +++ b/drivers/staging/vt6655/dpc.c
> @@ -43,7 +43,7 @@ static bool vnt_rx_data(struct vnt_private *priv, struct sk_buff *skb,
>   	struct ieee80211_rx_status rx_status = { 0 };
>   	struct ieee80211_hdr *hdr;
>   	__le16 fc;
> -	u8 *rsr, *new_rsr, *rssi;
> +	u8 *rssi;
I rather this was not removed, these are error reporting.

I have a patch for them that I will send shortly.


Malcolm


>   	__le64 *tsf_time;
>   	u16 frame_size;
>   	int ii, r;
> @@ -88,9 +88,7 @@ static bool vnt_rx_data(struct vnt_private *priv, struct sk_buff *skb,
>
>   	tsf_time = (__le64 *)(skb_data + bytes_received - 12);
>   	sq = skb_data + bytes_received - 4;
> -	new_rsr = skb_data + bytes_received - 3;
>   	rssi = skb_data + bytes_received - 2;
> -	rsr = skb_data + bytes_received - 1;
>
>   	RFvRSSITodBm(priv, *rssi, &rx_dbm);
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/