linux-kernel - Re: [PATCHv3] staging: vt6656: removed erroneous else statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150201010924.GA25164@kroah.com>
Date:	Sat, 31 Jan 2015 17:09:24 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Derrick Greenspan <derrick.greenspan@...ghts.ucf.edu>
Cc:	Malcolm Priestley <tvboxspy@...il.com>,
	Forest Bond <forest@...ttletooquiet.net>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv3] staging: vt6656: removed erroneous else statement

On Sat, Jan 31, 2015 at 02:05:21PM -0500, Derrick Greenspan wrote:
> This patch fixes the checkpatch.pl warning:
> 
> WARNING: else is not generally useful after a break or return
> 559: FILE: drivers/staging/vt6656/rxtx.c:559:
> return vnt_rxtx_datahead_g_fb(tx_context, &buf->data_head);
> } else {
> 
> Signed-off-by: Derrick Greenspan <derrick.greenspan@...ghts.ucf.edu>
> ---
> Changes in v2:
>  - Hopefully fixed whitespace!
> Changes in v3:
>  - Fixed GCC compiler warning

I don't believe you really did fix that warning, as you still are
creating a variable in the middle of a function, which isn't allowed.

Just leave the existing code as-is, this is getting too messy.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/