linux-kernel - Re: checkpatch: length of git commit IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1422822955.12856.7.camel@perches.com>
Date:	Sun, 01 Feb 2015 12:35:55 -0800
From:	Joe Perches <joe@...ches.com>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: checkpatch: length of git commit IDs

On Sun, 2015-02-01 at 21:30 +0100, Stefan Richter wrote:
> On Feb 01 Joe Perches wrote:
> > On Sun, 2015-02-01 at 20:59 +0100, Stefan Richter wrote:
> > > I was just told that 12 is less than 12:
> > > 
> > > > ERROR: Please use 12 or more chars for the git commit ID like: 'Commit
> > > > 01234567890ab ("commit description")' #5: 
> > > > Commit 2a48fc0ab242 "block: autoconvert trivial BKL users to private
> > 
> > Yeah, that message isn't very descriptive.
> > 
> > It really wants parentheses around the commit
> > message like:
> > 
> > Commit 2a48fc0ab242 ("block: autoconvert trivial BKL users to private
> > 
> > Try the version in -next.  I think it has  a
> > better message description.
> 
> Thanks for the tip; this works for me.  (checkpatch.pl from current -next
> does actually not complain about the line without parentheses.)

Hmm, I think that should be a defect.

Can you send me your git format-patch output please?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/