linux-kernel - Re: [PATCH v3 07/10] ARM: dts: sunxi: Add usb3_vbus regulator to common regulators dtsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGb2v64SaEQiJ1LYUGWj+cv_UG-oEn_gtUuoGGndGuX_pJbZWQ@mail.gmail.com>
Date:	Sun, 1 Feb 2015 15:28:20 +0100
From:	Chen-Yu Tsai <wens@...e.org>
To:	Maxime Ripard <maxime.ripard@...e-electrons.com>
Cc:	Mike Turquette <mturquette@...aro.org>,
	Emilio Lopez <emilio@...pez.com.ar>,
	Rob Herring <robh+dt@...nel.org>,
	Grant Likely <grant.likely@...aro.org>,
	Kishon Vijay Abraham I <kishon@...com>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	devicetree <devicetree@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-sunxi <linux-sunxi@...glegroups.com>
Subject: Re: [PATCH v3 07/10] ARM: dts: sunxi: Add usb3_vbus regulator to
 common regulators dtsi

On Sun, Feb 1, 2015 at 3:20 PM, Maxime Ripard
<maxime.ripard@...e-electrons.com> wrote:
> On Wed, Jan 28, 2015 at 03:54:12AM +0800, Chen-Yu Tsai wrote:
>> Some SoCs have a total of 4 possible USB controllers. One such example
>> is the A80, which has one USB3 dual role device and 3 EHCI/OHCI pairs.
>>
>> Add a common VBUS regulator for the last host controller.
>>
>> Signed-off-by: Chen-Yu Tsai <wens@...e.org>
>> ---
>>  arch/arm/boot/dts/sunxi-common-regulators.dtsi | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sunxi-common-regulators.dtsi b/arch/arm/boot/dts/sunxi-common-regulators.dtsi
>> index e02baa66b33c..97fe8d73c4f7 100644
>> --- a/arch/arm/boot/dts/sunxi-common-regulators.dtsi
>> +++ b/arch/arm/boot/dts/sunxi-common-regulators.dtsi
>> @@ -130,6 +130,16 @@
>>               status = "disabled";
>>       };
>>
>> +     reg_usb3_vbus: usb3-vbus {
>> +             compatible = "regulator-fixed";
>> +             pinctrl-names = "default";
>> +             regulator-name = "usb3-vbus";
>> +             regulator-min-microvolt = <5000000>;
>> +             regulator-max-microvolt = <5000000>;
>> +             enable-active-high;
>> +             status = "disabled";
>> +     };
>> +
>
> I don't think you replied to this one. What other SoC is using the
> USB3 regulator? Is it worth it to put it in there and bloat all the
> other DTS for something that is only used on a single board so far?

Yes I missed this one. The only other one is A31, which has OHCI2,
but no board routes it to a USB connector with a VBUS regulator.

So yeah, I'll move it to the board DTS.

ChenYu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/