linux-kernel - Re: [PATCH v2 05/12] drm: rockchip/vop: filter interlace display mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 Feb 2015 16:00:58 +0800
From:	Daniel Kurtz <djkurtz@...omium.org>
To:	Yakir Yang <ykk@...k-chips.com>
Cc:	David Airlie <airlied@...ux.ie>,
	Russell King <rmk+kernel@....linux.org.uk>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Fabio Estevam <fabio.estevam@...escale.com>,
	Shawn Guo <shawn.guo@...aro.org>,
	Rob Clark <robdclark@...il.com>,
	Mark Yao <mark.yao@...k-chips.com>,
	Daniel Vetter <daniel@...ll.ch>,
	dri-devel <dri-devel@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	dbehr@...omoum.org,
	Heiko Stübner <mmind00@...glemail.com>,
	Douglas Anderson <dianders@...omium.org>,
	Stéphane Marchesin <marcheu@...omium.org>,
	rockchip-discuss <rockchip-discuss@...omium.org>
Subject: Re: [PATCH v2 05/12] drm: rockchip/vop: filter interlace display mode

Hi ykk,

On Fri, Jan 30, 2015 at 7:29 PM, Yakir Yang <ykk@...k-chips.com> wrote:
> RK3288's VOP do not support INTERLACE display mode, so we should
> remove those modes out of mode_ok list.
>
> Signed-off-by: Yakir Yang <ykk@...k-chips.com>


Reviewed-by: Daniel Kurtz <djkurtz@...omium.org>

Can you move this patch out of your hdmi audio patch set, and send it
separately?
This fix is independent of the others.

Thanks!


> ---
> Changes in v2:
> - filter interlace display mode for rockchip vop
>
>  drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> index 9a5c571..bedab42 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> @@ -808,7 +808,8 @@ static bool vop_crtc_mode_fixup(struct drm_crtc *crtc,
>                                 const struct drm_display_mode *mode,
>                                 struct drm_display_mode *adjusted_mode)
>  {
> -       if (adjusted_mode->htotal == 0 || adjusted_mode->vtotal == 0)
> +       if (adjusted_mode->htotal == 0 || adjusted_mode->vtotal == 0 ||
> +           (adjusted_mode->flags & DRM_MODE_FLAG_INTERLACE))
>                 return false;
>
>         return true;
> --
> 2.1.2
>
>
> --
> You received this message because you are subscribed to the Google Groups "rockchip-discuss" group.
> To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/rockchip-discuss/1422617388-25476-1-git-send-email-ykk%40rock-chips.com.
>
> To unsubscribe from this group and stop receiving emails from it, send an email to rockchip-discuss+unsubscribe@...omium.org.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/