linux-kernel - Re: [PATCH v2 1/3] hv: hv_util: move vmbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 02 Feb 2015 09:44:14 +0008
From:	Jason Wang <jasowang@...hat.com>
To:	Dexuan Cui <decui@...rosoft.com>
Cc:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	driverdev-devel@...uxdriverproject.org, olaf@...fle.de,
	apw@...onical.com, kys@...rosoft.com, vkuznets@...hat.com,
	haiyangz@...rosoft.com
Subject: Re: [PATCH v2 1/3] hv: hv_util: move vmbus_open() to a later place



On Mon, Feb 2, 2015 at 12:35 PM, Dexuan Cui <decui@...rosoft.com> wrote:
> Before the line vmbus_open() returns, srv->util_cb can be already 
> running
> and the variables, like util_fw_version, are needed by the 
> srv->util_cb.

A questions is why we do this for util only? Can callbacks of other 
devices be called before vmbus_open() returns?

> 
> So we have to make sure the variables are initialized before the 
> vmbus_open().
> 
> CC: "K. Y. Srinivasan" <kys@...rosoft.com>
> Reviewed-by: Vitaly Kuznetsov <vkuznets@...hat.com>
> Signed-off-by: Dexuan Cui <decui@...rosoft.com>
> ---
> 
> v2:
> This is a RESEND.
> I just added Vitaly's Reviewed-by.
> 
>  drivers/hv/hv_util.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/hv/hv_util.c b/drivers/hv/hv_util.c
> index 3b9c9ef..c5be773 100644
> --- a/drivers/hv/hv_util.c
> +++ b/drivers/hv/hv_util.c
> @@ -340,12 +340,8 @@ static int util_probe(struct hv_device *dev,
>  
>  	set_channel_read_state(dev->channel, false);
>  
> -	ret = vmbus_open(dev->channel, 4 * PAGE_SIZE, 4 * PAGE_SIZE, NULL, 
> 0,
> -			srv->util_cb, dev->channel);
> -	if (ret)
> -		goto error;
> -
>  	hv_set_drvdata(dev, srv);
> +

This seems unnecessary.
> 
>  	/*
>  	 * Based on the host; initialize the framework and
>  	 * service version numbers we will negotiate.
> @@ -365,6 +361,11 @@ static int util_probe(struct hv_device *dev,
>  		hb_srv_version = HB_VERSION;
>  	}
>  
> +	ret = vmbus_open(dev->channel, 4 * PAGE_SIZE, 4 * PAGE_SIZE, NULL, 
> 0,
> +			srv->util_cb, dev->channel);
> +	if (ret)
> +		goto error;
> +
>  	return 0;
>  
>  error:
> -- 
> 1.9.1
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/