linux-kernel - Re: [PATCH] spi: atmel: cleanup wait_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150202120850.GN21293@sirena.org.uk>
Date:	Mon, 2 Feb 2015 12:08:50 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Nicholas Mc Guire <hofrat@...dl.org>
Cc:	Nicolas Ferre <nicolas.ferre@...el.com>, linux-spi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: atmel: cleanup wait_for_completion return handling

On Sun, Feb 01, 2015 at 06:42:11AM -0500, Nicholas Mc Guire wrote:

> return type of wait_for_completion_timeout is unsigned long not int, this
> patch adds an appropriate variable and fixes up the assignment.
> Further it removes the else branch as the only thing it was
> doing is assigning ret to 0 - but ret is never used thereafter so that
> is not needed. As the string in dev_err already states "timeout" there
> is little point in printing the 0 here.
> 
> directly rather than adding a additional appropriately typed variable.

Your commit message appears a bit garbled here...

> Patch is against 3.19.0-rc6 -next-20150130

Which?

>  			as->done_status = -EIO;
> -		} else {
> -			ret = 0;
> -		}
> +		}

This appears to be introducing some whitespace damage, please fix and
resend.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)