linux-kernel - Re: [PATCH] media:dvb-frontends:Change setting of dtv_frontend_properties modulation to the correct value in the function,hd29l2_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 02 Feb 2015 16:40:43 +0200
From:	Antti Palosaari <crope@....fi>
To:	Nicholas Krause <xerofoify@...il.com>
CC:	mchehab@....samsung.com, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media:dvb-frontends:Change setting of dtv_frontend_properties
 modulation to the correct value in the function,hd29l2_get_frontend

Moikka!
That patch is not correct and will not even compile. Problem is that 
QAM_4NR and QAM_4 are not defined (OK, QPSK is QAM-4).

regards
Antti

On 02/02/2015 04:34 PM, Nicholas Krause wrote:
> Changes the values in the switch statement of the function,d29l2_get_frontend
> to use the proper value for the dtv_frontend_properties modulation value. Further
> more this changes the values of case 0 and case 1 to use the correct values of
> QAM_4NR and QAM_4 respectfully.
>
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> ---
>   drivers/media/dvb-frontends/hd29l2.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/dvb-frontends/hd29l2.c b/drivers/media/dvb-frontends/hd29l2.c
> index d7b9d54..48cafc9 100644
> --- a/drivers/media/dvb-frontends/hd29l2.c
> +++ b/drivers/media/dvb-frontends/hd29l2.c
> @@ -579,11 +579,11 @@ static int hd29l2_get_frontend(struct dvb_frontend *fe)
>   	switch ((buf[0] >> 0) & 0x07) {
>   	case 0: /* QAM4NR */
>   		str_constellation = "QAM4NR";
> -		c->modulation = QAM_AUTO; /* FIXME */
> +		c->modulation = QAM_4NR;
>   		break;
>   	case 1: /* QAM4 */
>   		str_constellation = "QAM4";
> -		c->modulation = QPSK; /* FIXME */
> +		c->modulation = QAM_4;
>   		break;
>   	case 2:
>   		str_constellation = "QAM16";
>

-- 
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/