linux-kernel - Re: [PATCH v4 01/13] clk: samsung: exynos5433: Add binding document for Exynos5433 clock domains

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 3 Feb 2015 01:44:25 +0900
From:	Chanwoo Choi <cwchoi00@...il.com>
To:	Sylwester Nawrocki <s.nawrocki@...sung.com>
Cc:	Tomasz Figa <tomasz.figa@...il.com>,
	Mike Turquette <mturquette@...aro.org>,
	Kukjin Kim <kgene@...nel.org>,
	"pankaj.dubey@...sung.com" <pankaj.dubey@...sung.com>,
	sangbae90.lee@...sung.com,
	"inki.dae@...sung.com" <inki.dae@...sung.com>,
	"chanho61.park@...sung.com" <chanho61.park@...sung.com>,
	Seung-Woo Kim <sw0312.kim@...sung.com>,
	linux-samsung-soc <linux-samsung-soc@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 01/13] clk: samsung: exynos5433: Add binding document
 for Exynos5433 clock domains

Hi Sylwester,

On Tue, Feb 3, 2015 at 1:25 AM, Sylwester Nawrocki
<s.nawrocki@...sung.com> wrote:
> Hi Chanwoo,
>
> On 02/02/15 16:51, Chanwoo Choi wrote:
>> On Mon, Feb 2, 2015 at 11:40 PM, Sylwester Nawrocki
>> <s.nawrocki@...sung.com> wrote:
>>> > On 02/02/15 15:08, Chanwoo Choi wrote:
>>> >
>>>> >> OK, I'll add more following information:
>>>> >> I'll send only patch1 with following information.
>>>> >>
>>>> >> + - clocks: list of clock identifiers which are fed as the input to
>>>> >> +       the given clock controller. Please refer the next section to
>>>> >> +       find the input clocks for a given controller.
>>>> >> + - clock-names: list of names of clocks which are fed as the input
>>>> >> +       to the given clock controller.
>>>> >> +
>>> >
>>> > Perhaps:
>>> >
>>> > + - clocks: list of the clock controller input clock identifiers,
>>> >         from common clock bindings. Please refer the next section
>>> >         to find the input clocks for a given controller.
>>> >
>>> > +- clock-names: list of the clock controller input clock names,
>>> >         as described in clock-bindings.txt.
>>> >
>>> > ?
>>> > It's fine to resend just updated first patch from each series.
>> OK,
>> I'll modify the comment of 'clocks' and 'clock-names' and send only first patch.
>>
>> I have a question. Do you prefer to add the list of input clocks for
>> each clock domain as following?
>> Or it is not necessary?
>>
>>            +       Input clocks for top clock controller:
>>            +               - oscclk
>>            +               - sclk_mphy_pll
>>            +               - sclk_mfc_pll
>>            +               - sclk_bus_pll
>
> We are supposed to document all required input clocks somehow, I would
> keep the list in such form. The (example) cmu nodes are also a good
> documentation IMHO, they also show clearly which cmu (block) given clock
> is sourced from.

I agree that the binding document have to contain all required information.
The binding document of exynos5433-clock will contain all input clocks for
each clock domain. Also, I'll modify the description of 'clocks'/'clock-names'
according to your comment and then I'll re-send only updated first
patch for document.

Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/