linux-kernel - Re: [PATCH 1/3] ARM: OMAP2+: gpmc: Fix writing in gpmc_cs_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 Feb 2015 09:08:27 -0800
From:	Tony Lindgren <tony@...mide.com>
To:	Roger Quadros <rogerq@...com>
Cc:	Semen Protsenko <semen.protsenko@...ballogic.com>,
	linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] ARM: OMAP2+: gpmc: Fix writing in gpmc_cs_set_memconf

* Roger Quadros <rogerq@...com> [150126 01:38]:
> On 24/01/15 22:28, Semen Protsenko wrote:
> > Some GPMC_CONFIG7 register bits marked as "RESERVED", means they
> > shouldn't be overwritten. A typical approach to handle such bits called
> > "Read-Modify-Write". Writing procedure used in gpmc_cs_set_memconf()
> > utilizes RMW technique, but implemented incorrectly. Due to obvious typo
> > in code read register value is being rewritten by another value, which
> > leads to loss of read RESERVED bits. This patch fixes this.
> > 
> > While at it, replace magic numbers with named constants to improve code
> > readability.
> > 
> > Signed-off-by: Semen Protsenko <semen.protsenko@...ballogic.com>
> 
> This is much nicer.
> 
> Acked-by: Roger Quadros <rogerq@...com>

Roger will queue this so:

Acked-by: Tony Lindgren <tony@...mide.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/