linux-kernel - Re: [PATCH v2] x86/devicetree: Fix build for amd64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 2 Feb 2015 18:36:55 +0000 (GMT)
From:	"Maciej W. Rozycki" <macro@...ux-mips.org>
To:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
cc:	Jiang Liu <jiang.liu@...ux.intel.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	David Rientjes <rientjes@...gle.com>,
	Oren Twaig <oren@...lemp.com>, Jan Beulich <JBeulich@...e.com>,
	Christoph Lameter <cl@...ux.com>,
	Jan Kiszka <jan.kiszka@...mens.com>,
	linux-kernel@...r.kernel.org,
	David Vrabel <david.vrabel@...rix.com>,
	Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v2] x86/devicetree: Fix build for amd64

On Mon, 2 Feb 2015, Ricardo Ribalda Delgado wrote:

> apic_force_enable is not defined for amd64.
> 
> Without this patch:
> 
> LD      init/built-in.o
> arch/x86/built-in.o: In function `dtb_lapic_setup':
> kernel/devicetree.c:155:
> undefined reference to `apic_force_enable'
> Makefile:923: recipe for target 'vmlinux' failed
> make: *** [vmlinux] Error 1
> 
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
> ---
> 
> v2: Suggested by: Jiang Liu <jiang.liu@...ux.intel.com>
> 
> How about defining a version of apic_force_enable()
> for X86_64 in apic.h which just return failure?
> 
>  arch/x86/kernel/apic/apic.c | 6 ++++++
>  1 file changed, 6 insertions(+)

 I think the original suggestion made sense, move your stuff to apic.h so 
that the call is optimised away rather than keeping it here.

  Maciej
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/