linux-kernel - Re: [PATCH] mtd: Expose partition offset to the drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 02 Feb 2015 20:37:31 +0100
From:	Richard Weinberger <richard@....at>
To:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>,
	Richard Weinberger <richard.weinberger@...il.com>
CC:	David Woodhouse <dwmw2@...radead.org>,
	Brian Norris <computersforpeace@...il.com>,
	"linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mtd: Expose partition offset to the drivers

Hi!

Am 02.02.2015 um 20:33 schrieb Ricardo Ribalda Delgado:
> Hello
> 
> On Mon, Feb 2, 2015 at 8:17 PM, Richard Weinberger
> <richard.weinberger@...il.com> wrote:
>> On Mon, Feb 2, 2015 at 5:22 PM, Ricardo Ribalda Delgado
>>
>> Can you please also send a patch which shows the usage of this new function
>> by a driver?
> 
> It is currently out of tree, but here you can see the relevant code:
> 
> mtd_offset=mtd_get_device_offset(mtd);
> put_mtd_device(mtd);
> if (do_jmp){
>     ret=qt5023_hwicap_reset(head,mtd_offset);
>     if (ret){
>         dev_err(&head->pci_dev->dev,"error: Failed to jump to new bitfile\n");
>         vfree(buffer);
>         release_firmware(firmware);
>         return -EIO;
>     }
>     qt5023_spi_restart(head);
> }

Hmm, will we ever need the new function for in-tree drivers?
In general we add new functions only if they have an in-tree user
for it.

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/