linux-kernel - Re: [PATCH] clk: pxa: fix pxa27x_clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 02 Feb 2015 21:17:58 +0100
From:	Robert Jarzmik <robert.jarzmik@...e.fr>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	Mike Turquette <mturquette@...aro.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: pxa: fix pxa27x_clocks_init scope

Stephen Boyd <sboyd@...eaurora.org> writes:

> On 01/31/15 14:37, Robert Jarzmik wrote:
>> As pxa27x_clocks_init() is called from early boot stage, it has to be
>> reachable from pxa architecture code, as are pxa25x_clocks_init() and
>> pxa2xx_clock_init().
>>
>> Remove the static declaration, which was introduced before the order
>> issue between clocks and the timer was discovered (ie. the clocks have
>> to be available before the timer, all of this before initcalls are
>> called).
>>
>> Signed-off-by: Robert Jarzmik <robert.jarzmik@...e.fr>
>
> Is this supposed to go through the clk tree?
Ah you've got a point, it's a bit embarrassing, see below ...

> $ git grep pxa27x_clocks_init
> drivers/clk/pxa/clk-pxa27x.c:static int __init pxa27x_clocks_init(void)
> drivers/clk/pxa/clk-pxa27x.c:postcore_initcall(pxa27x_clocks_init);
> drivers/clk/pxa/clk-pxa27x.c:   pxa27x_clocks_init();
>
> Where's the early boot stage architecture calling code?
It's there :
 - https://lkml.org/lkml/2015/1/12/1057
 - which ended up here in pxa/for-next tree:
   https://github.com/rjarzmik/linux/commit/a494a74dc52532ed0cef4633db007a08f847a0a8

Which happens to be my tree ...

Please forget about this patch, I don't know how I ended up doing this patch
... lack of coffee probably.

Cheers.

-- 
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/