linux-kernel - Re: [PATCH 1/2] arm64: adding cpu lookup functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 Feb 2015 14:20:09 -0700
From:	Mathieu Poirier <mathieu.poirier@...aro.org>
To:	Will Deacon <will.deacon@....com>
Cc:	Catalin Marinas <Catalin.Marinas@....com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] arm64: adding cpu lookup functionality

On 2 February 2015 at 06:50, Will Deacon <will.deacon@....com> wrote:
> On Fri, Jan 30, 2015 at 10:54:25PM +0000, mathieu.poirier@...aro.org wrote:
>> From: Mathieu Poirier <mathieu.poirier@...aro.org>
>>
>> Adding a lookup function allowing for quick and easy mapping
>> between processor HWID (as found, for example) in DT specifications
>> and the CPU index known to the kernel.
>>
>> Signed-off-by: Mathieu Poirier <mathieu.poirier@...aro.org>
>> ---
>>  arch/arm64/include/asm/smp_plat.h | 12 ++++++++++++
>>  1 file changed, 12 insertions(+)
>>
>> diff --git a/arch/arm64/include/asm/smp_plat.h b/arch/arm64/include/asm/smp_plat.h
>> index 59e282311b58..8e4b011303b1 100644
>> --- a/arch/arm64/include/asm/smp_plat.h
>> +++ b/arch/arm64/include/asm/smp_plat.h
>> @@ -19,6 +19,7 @@
>>  #ifndef __ASM_SMP_PLAT_H
>>  #define __ASM_SMP_PLAT_H
>>
>> +#include <linux/cpumask.h>
>>  #include <asm/types.h>
>>
>>  struct mpidr_hash {
>> @@ -40,4 +41,15 @@ static inline u32 mpidr_hash_size(void)
>>  extern u64 __cpu_logical_map[NR_CPUS];
>>  #define cpu_logical_map(cpu)    __cpu_logical_map[cpu]
>>
>> +static inline int get_logical_index(u64 mpidr)
>> +{
>> +     int cpu;
>> +
>> +     for (cpu = 0; cpu < nr_cpu_ids; cpu++)
>> +             if (cpu_logical_map(cpu) == mpidr)
>> +                     return cpu;
>> +     return -EINVAL;
>> +}
>
> Can you not achieve the same thing using arch_find_n_match_cpu_physical_id
> in the coresight code?
>
> Will

I ended up using "of_get_cpu_node()", which uses
"arch_find_n_match_cpu_physical_id()".  Thanks for pointing this out.

Mathieu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/