linux-kernel - Re: [PATCH] jfs: Deletion of an unnecessary check before the function call "unload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 02 Feb 2015 16:32:35 -0600
From:	Dave Kleikamp <dave.kleikamp@...cle.com>
To:	SF Markus Elfring <elfring@...rs.sourceforge.net>,
	Dave Kleikamp <shaggy@...nel.org>,
	jfs-discussion@...ts.sourceforge.net
CC:	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH] jfs: Deletion of an unnecessary check before the function
 call "unload_nls"

On 02/01/2015 10:15 AM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sun, 1 Feb 2015 17:00:24 +0100
> 
> The unload_nls() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Thanks! I'll push this upstream.

Dave

> ---
>  fs/jfs/super.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/jfs/super.c b/fs/jfs/super.c
> index 16c3a95..5d30c56 100644
> --- a/fs/jfs/super.c
> +++ b/fs/jfs/super.c
> @@ -619,8 +619,7 @@ out_mount_failed:
>  	iput(sbi->direct_inode);
>  	sbi->direct_inode = NULL;
>  out_unload:
> -	if (sbi->nls_tab)
> -		unload_nls(sbi->nls_tab);
> +	unload_nls(sbi->nls_tab);
>  out_kfree:
>  	kfree(sbi);
>  	return ret;
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/