linux-kernel - [PATCH 2/5] powerpc: Remove powerpc specific byteswap from bt8xx DVB driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1422941785-22557-3-git-send-email-david@gibson.dropbear.id.au>
Date:	Tue,  3 Feb 2015 16:36:22 +1100
From:	David Gibson <david@...son.dropbear.id.au>
To:	benh@...nel.crashing.org, mpe@...erman.id.au, paulus@...ba.org,
	agraf@...e.de
Cc:	aik@...abs.ru, mdroth@...ibm.com, linuxppc-dev@...ts.ozlabs.org,
	linux-kernel@...r.kernel.org,
	David Gibson <david@...son.dropbear.id.au>,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	Peter Hettkamp <peter.hettkamp@...-tel.de>
Subject: [PATCH 2/5] powerpc: Remove powerpc specific byteswap from bt8xx DVB driver

The bt8xx PCI DVB driver includes a powerpc specific hack, using one of
the powerpc specific byteswapping functions in an IO helper macro.

There's no reason to use the powerpc specific function instead of a
generic byteswap, so this patch removes it.  I'm not sure if the powerpc
specific memory barrier is required, so I'm leaving that in.

Cc: Mauro Carvalho Chehab <mchehab@....samsung.com>
Cc: Peter Hettkamp <peter.hettkamp@...-tel.de>

Signed-off-by: David Gibson <david@...son.dropbear.id.au>
---
 drivers/media/pci/bt8xx/bt878.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/pci/bt8xx/bt878.h b/drivers/media/pci/bt8xx/bt878.h
index d19b592..bbb76bb 100644
--- a/drivers/media/pci/bt8xx/bt878.h
+++ b/drivers/media/pci/bt8xx/bt878.h
@@ -145,12 +145,12 @@ void bt878_stop(struct bt878 *bt);
 #if defined(__powerpc__)	/* big-endian */
 static inline void io_st_le32(volatile unsigned __iomem *addr, unsigned val)
 {
-	st_le32(addr, val);
+	*addr = cpu_to_le32(val);
 	eieio();
 }
 
 #define bmtwrite(dat,adr)  io_st_le32((adr),(dat))
-#define bmtread(adr)       ld_le32((adr))
+#define bmtread(adr)       le32_to_cpu(*((volatile __le32 *)(adr)))
 #else
 #define bmtwrite(dat,adr)  writel((dat), (adr))
 #define bmtread(adr)       readl(adr)
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/