linux-kernel - Re: [PATCH 1/2] ALSA: line6: use msecs_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hoapbe5f2.wl-tiwai@suse.de>
Date:	Tue, 03 Feb 2015 10:00:01 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Nicholas Mc Guire <hofrat@...dl.org>
Cc:	Jaroslav Kysela <perex@...ex.cz>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Chris Rorvick <chris@...vick.com>,
	Stefan Hajnoczi <stefanha@...il.com>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ALSA: line6: use msecs_to_jiffies for conversion

At Tue,  3 Feb 2015 02:38:39 -0500,
Nicholas Mc Guire wrote:
> 
> This is only an API consolidation and should make things more readable
> it replaces var * HZ / 1000 by msecs_to_jiffies(var).
> 
> 
> Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>
> ---
> 
> Converting milliseconds to jiffies by val * HZ / 1000 is technically
> not wrong but msecs_to_jiffies(val) is the cleaner solution and handles
> all corner cases correctly. This is a minor API cleanup only.
> 
> Patch was only compile tested for x86_64_defconfig + CONFIG_SOUND=y,
> CONFIG_SND_USB_POD=m (implies CONFIG_SND_USB_LINE6=y)
> 
> Patch is against 3.0.19-rc6 (localversion = -next-20150202)

Applied, thanks.


Takashi

> 
>  sound/usb/line6/driver.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/usb/line6/driver.c b/sound/usb/line6/driver.c
> index 2328ec9..3cf12cc 100644
> --- a/sound/usb/line6/driver.c
> +++ b/sound/usb/line6/driver.c
> @@ -166,7 +166,7 @@ void line6_start_timer(struct timer_list *timer, unsigned int msecs,
>  		       void (*function)(unsigned long), unsigned long data)
>  {
>  	setup_timer(timer, function, data);
> -	mod_timer(timer, jiffies + msecs * HZ / 1000);
> +	mod_timer(timer, jiffies + msecs_to_jiffies(msecs));
>  }
>  EXPORT_SYMBOL_GPL(line6_start_timer);
>  
> -- 
> 1.7.10.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/