linux-kernel - RFC arch/sh/kernel/traps_64.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150203093758.GA27963@opentech.at>
Date:	Tue, 3 Feb 2015 10:37:58 +0100
From:	Nicholas Mc Guire <der.herr@...r.at>
To:	"James E.J. Bottomley" <jejb@...isc-linux.org>
Cc:	Helge Deller <deller@....de>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	linux-parisc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: RFC arch/sh/kernel/traps_64.c - unclear if/else construct


Hi !

 scanning for  if STATEMENT else STATEMENT  triggered here - and it does look
like it needs a fix-up or at least some comments.

<snip?
int hpux_sysfs(int opcode, unsigned long arg1, unsigned long arg2)
{
	 int fstype;
	 ...
		  /* String could be altered by userspace after strlen_user() */
		  fsname[len - 1] = '\0';

		  printk(KERN_DEBUG "that is '%s' as (char *)\n", fsname);
		  if ( !strcmp(fsname, "hfs") ) {
			   fstype = 0;
		  } else {
			   fstype = 0;
		  }  
		     
		  kfree(fsname);

		  printk(KERN_DEBUG "returning fstype=%d\n", fstype);
		  return fstype; /* something other than default */
<snip>

 The if-else here has no effect and the printk will not convey any information
as its always fstype==0, finally the return statement comment indicates that it
should not be the default...

 Can't come up with a reasonable cleanup patch here - but this looks like it
needs a review.

thx!
hofrat
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/