linux-kernel - Re: [PATCH] Add ARCH_MIGHT_HAVE_VGA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150203110849.7907f175@canb.auug.org.au>
Date:	Tue, 3 Feb 2015 11:08:49 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Yoshinori Sato <ysato@...rs.sourceforge.jp>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Linux-Arch <linux-arch@...r.kernel.org>
Subject: Re: [PATCH] Add ARCH_MIGHT_HAVE_VGA_CONSOLE

Hi Arnd,

On Mon, 02 Feb 2015 21:11:50 +0100 Arnd Bergmann <arnd@...db.de> wrote:
>
> On Tuesday 03 February 2015 00:48:20 Yoshinori Sato wrote:
> 
> > --- a/arch/arm/Kconfig
> > +++ b/arch/arm/Kconfig
> > @@ -76,6 +76,7 @@ config ARM
> >        select PERF_USE_VMALLOC
> >        select RTC_LIB
> >        select SYS_SUPPORTS_APM_EMULATION
> >+       select ARCH_MIGHT_HAVE_VGA_CONSOLE if ARCH_FOOTBRIDGE || ARCH_INTEGRATOR || ARCH_NETWINDER
> >        # Above selects are sorted alphabetically; please add new ones
> >        # according to that.  Thanks.
> >        help
> 
> You did not read the comment in the patch context: This list of selects is
> sorted alphabetically in order to avoid merge conflicts. Please keep it this
> way.

Why would you not just put the "select ARCH_MIGHT_HAVE_VGA_CONSOLE"
under each of those other config symbols and further restrict the
possibility of conflicts?

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Content of type "application/pgp-signature" skipped