linux-kernel - Re: [PATCH] zram: fix umount-reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150203141525.GA1050@swordfish>
Date:	Tue, 3 Feb 2015 23:15:25 +0900
From:	Sergey Senozhatsky <sergey.senozhatsky@...il.com>
To:	Ganesh Mahendran <opensource.ganesh@...il.com>
Cc:	Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
	sergey.senozhatsky.work@...il.com,
	Minchan Kim <minchan@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jerome Marchand <jmarchan@...hat.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] zram: fix umount-reset_store-mount race condition

Hello,

On (02/03/15 22:05), Ganesh Mahendran wrote:
> >         zram->disksize = 0;
> > -       if (reset_capacity)
> > -               set_capacity(zram->disk, 0);
> 
> How about keep this here? Protected by zram->init_lock.
>            set_capacity(zram->disk, 0);

why?

	-ss
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/