linux-kernel - Re: [RFC] change non-atomic bitops method

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <30242.1422976483@warthog.procyon.org.uk>
Date:	Tue, 03 Feb 2015 15:14:43 +0000
From:	David Howells <dhowells@...hat.com>
To:	Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= 
	<u.kleine-koenig@...gutronix.de>
Cc:	dhowells@...hat.com, "Wang\, Yalin" <Yalin.Wang@...ymobile.com>,
	"'arnd\@arndb.de'" <arnd@...db.de>,
	"'linux-arch\@vger.kernel.org'" <linux-arch@...r.kernel.org>,
	"'linux-kernel\@vger.kernel.org'" <linux-kernel@...r.kernel.org>,
	"'linux\@arm.linux.org.uk'" <linux@....linux.org.uk>,
	"'linux-arm-kernel\@lists.infradead.org'" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [RFC] change non-atomic bitops method

Uwe Kleine-König  wrote:

> Might be a matter of taste, but this check is equivalent to
> 
> 	*p != (*p | mask)
> 
> which is what you really want to test for.

I would argue that this is less clear as to what's going on.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/