linux-kernel - Re: [PATCH V2 2/2] spmi: pmic_arb: add support for hw version 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54D10210.5030106@mm-sol.com>
Date:	Tue, 03 Feb 2015 19:14:56 +0200
From:	Stanimir Varbanov <svarbanov@...sol.com>
To:	Gilad Avidov <gavidov@...eaurora.org>
CC:	sdharia@...eaurora.org, mlocke@...eaurora.org,
	linux-arm-msm@...r.kernel.org, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org, iivanov@...sol.com,
	galak@...eaurora.org, agross@...eaurora.org
Subject: Re: [PATCH V2 2/2] spmi: pmic_arb: add support for hw version 2

On 02/03/2015 06:59 PM, Gilad Avidov wrote:
> Hi Stan,
> 
> Thank you for the review.
> 
> On 2/3/2015 2:59 AM, Stanimir Varbanov wrote:
>> Hi Gilad,
>>
>> Thanks for the patch.
>>
>> On 01/31/2015 02:46 AM, Gilad Avidov wrote:
>>> Qualcomm PMIC Arbiter version-2 changes from version-1 are:
>>>
>>> - Some different register offsets.
>>> - New channel register space, one per PMIC peripheral (ppid).
>>>    All tx traffic uses these channels.
>>> - New observer register space. All rx trafic uses this space.
>>> - Different command format for spmi command registers.
>>>
>>> Signed-off-by: Gilad Avidov <gavidov@...eaurora.org>
>>> Acked-by: Sagar Dharia <sdharia@...eaurora.org>
>>> ---
>>>   .../bindings/spmi/qcom,spmi-pmic-arb.txt           |   6 +-
>>>   drivers/spmi/spmi-pmic-arb.c                       | 310
>>> +++++++++++++++++----
>>>   2 files changed, 260 insertions(+), 56 deletions(-)
>>>

<snip>

>>>   +/* v1 offset per ee */
>>> +static u32 pmic_arb_offset_v1(struct spmi_pmic_arb_dev *pa, u8 sid,
>>> u16 addr)
>>> +{
>>> +    return 0x800 + 0x80 * (pa->channel);
>> no braces here and in below ops
> 
> will remove braces above.
> 
> About below:
> Did you mean to remove braces from ops such as:
> 
> (sid << 8) | (addr >> 8)
> and
> (opc << 27) | ((sid & 0xf) << 20) | (addr << 4) | (bc & 0x7)
> 
> ?

no, that's fine.

> 
> In the latter case I think the braces improve readability.

I think so, too.

-- 
regards,
Stan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/