lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 3 Feb 2015 10:40:08 -0800 From: Leonid Yegoshin <Leonid.Yegoshin@...tec.com> To: Guenter Roeck <linux@...ck-us.net>, Ralf Baechle <ralf@...ux-mips.org> CC: <linux-mips@...ux-mips.org>, <linux-kernel@...r.kernel.org>, "Atsushi Nemoto" <anemo@....ocn.ne.jp>, Matthew Wilcox <matthew.r.wilcox@...el.com> Subject: Re: mips: Re-introduce copy_user_page On 01/30/2015 09:23 PM, Guenter Roeck wrote: > Commit bcd022801ee5 ("MIPS: Fix COW D-cache aliasing on fork") replaced > the inline function copy_user_page for mips with an external reference, > but neglected to introduce the actual non-inline function. Restore it. > > Fixes: bcd022801ee5 ("MIPS: Fix COW D-cache aliasing on fork") > Fixes: 4927b7d77c00 ("dax,ext2: replace the XIP page fault handler with the DAX page fault handler") > Cc: Atsushi Nemoto <anemo@....ocn.ne.jp> > Cc: Matthew Wilcox <matthew.r.wilcox@...el.com> > Signed-off-by: Guenter Roeck <linux@...ck-us.net> > Why do you use copy_user_page? It doesn't work properly in HIGHMEM environment and it is excluded from MIPS because of that, I believe. You should use copy_user_highpage() for user pages. - Leonid. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists