linux-kernel - Re: linux-next: Tree for Feb 3 (arc:defconfig build failure)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54D11C84.2060606@hurleysoftware.com>
Date:	Tue, 03 Feb 2015 14:07:48 -0500
From:	Peter Hurley <peter@...leysoftware.com>
To:	Guenter Roeck <linux@...ck-us.net>,
	Stephen Rothwell <sfr@...b.auug.org.au>
CC:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Vineet Gupta <vgupta@...opsys.com>
Subject: Re: linux-next: Tree for Feb 3 (arc:defconfig build failure)

On 02/03/2015 01:42 PM, Guenter Roeck wrote:
> On Tue, Feb 03, 2015 at 06:20:10PM +1100, Stephen Rothwell wrote:
>> Hi all,
>>
>> Changes since 20150202:
>>
>> The target-updates tree gained a conflict against Linus' tree.
>>
>> The clk tree gained conflicts against the arm-soc tree.
>>
>> Non-merge commits (relative to Linus' tree): 7173
>>  7143 files changed, 301126 insertions(+), 167764 deletions(-)
>>
>> ----------------------------------------------------------------------------
>>
> Building arc:defconfig ... failed
> --------------
> Error log:
> 
> drivers/built-in.o: In function `of_setup_earlycon':
> (.init.text+0xb3e): undefined reference to `arc_early_base_baud'
> drivers/built-in.o: In function `setup_earlycon':
> (.init.text+0xcd0): undefined reference to `arc_early_base_baud'
> make: *** [vmlinux] Error 1
> 
> This is due to "ARC: Dynamically determine BASE_BAUD from DeviceTree".
> arc:defconfig does not define CONFIG_SERIAL_8250 and thus also not
> CONFIG_SERIAL_8250_CONSOLE, but it looks like it is mandatory
> after this patch.
> 
> Guenter

Thanks for the report. Does the patch below fix the build breakage?

Regards,
Peter Hurley

--- >% ---
Subject: [PATCH] ARC: Fix earlycon build breakage

Commit ffb7fcd66f14 ("ARC: Dynamically determine BASE_BAUD from DeviceTree")
breaks arc:defconfig build:

       drivers/built-in.o: In function `of_setup_earlycon':
       (.init.text+0xb3e): undefined reference to `arc_early_base_baud'
       drivers/built-in.o: In function `setup_earlycon':
       (.init.text+0xcd0): undefined reference to `arc_early_base_baud'
       make: *** [vmlinux] Error 1

BASE_BAUD is only required for earlycon, which should depend on
CONFIG_SERIAL_EARLYCON.

Reported-by: Guenter Roeck <linux@...ck-us.net>
Signed-off-by: Peter Hurley <peter@...leysoftware.com>
---
 arch/arc/kernel/devtree.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arc/kernel/devtree.c b/arch/arc/kernel/devtree.c
index 5036d4c..e32b54a 100644
--- a/arch/arc/kernel/devtree.c
+++ b/arch/arc/kernel/devtree.c
@@ -17,7 +17,7 @@
 #include <asm/clk.h>
 #include <asm/mach_desc.h>
 
-#ifdef CONFIG_SERIAL_8250_CONSOLE
+#ifdef CONFIG_SERIAL_EARLYCON
 
 static unsigned int __initdata arc_base_baud;
 
-- 
2.2.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/