linux-kernel - Re: [PATCH] ntp: Fixup adjtimex freq validation on 32bit systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150203194543.GA21745@localhost.localdomain>
Date:	Tue, 3 Feb 2015 20:45:43 +0100
From:	Richard Cochran <richardcochran@...il.com>
To:	John Stultz <john.stultz@...aro.org>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...nel.org>,
	Sasha Levin <sasha.levin@...cle.com>, stable@...r.kernel.org
Subject: Re: [PATCH] ntp: Fixup adjtimex freq validation on 32bit systems

On Tue, Feb 03, 2015 at 10:57:38AM -0800, John Stultz wrote:
> Unfortunately the patch used LONG_MAX/MIN instead of
> LLONG_MAX/MIN, which was fine on 64bit systems, but being
> much smaller on 32bit systems caused false positives
> resulting in most direct frequency adjustments to fail w/
> EINVAL.

...

> One note:
> 0day kbuild bot complains about
> >> kernel/time/ntp.c:637: warning: comparison is always false due to limited range of data type
> >> kernel/time/ntp.c:639: warning: comparison is always false due to limited range of data type
> 
> We could fix this via adding an extra (BITS_PER_LONG == 64)
> case before we check these to avoid it, but that seemed a
> bit too ugly to me. Thoughts?

So the check is 64 bit only?  Might as well mark it like that
explicitly to avoid needless head scratching of 32 bit people.

Thanks,
Richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/