linux-kernel - Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150203200211.GF6508@saruman.tx.rr.com>
Date:	Tue, 3 Feb 2015 14:02:11 -0600
From:	Felipe Balbi <balbi@...com>
To:	Pali Rohár <pali.rohar@...il.com>
CC:	<balbi@...com>, Linux USB Mailing List <linux-usb@...r.kernel.org>,
	Pavel Machek <pavel@....cz>,
	Aaro Koskinen <aaro.koskinen@....fi>,
	Sebastian Reichel <sre@...nel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] usb: gadget: function: phonet: balance
 usb_ep_disable calls

Hi,

On Tue, Feb 03, 2015 at 08:57:11PM +0100, Pali Rohár wrote:
> > > > > > > > f_phonet's ->set_alt() method will call
> > > > > > > > usb_ep_disable() potentially on an endpoint which
> > > > > > > > is already disabled. That's something the
> > > > > > > > gadget/function driver must guarantee that it's
> > > > > > > > always balanced.
> > > > > > > > 
> > > > > > > > In order to balance the calls, just make sure the
> > > > > > > > endpoint was enabled before by means of checking
> > > > > > > > the validity of driver_data.
> > > > > > > > 
> > > > > > > > Reported-by: Pali Rohár <pali.rohar@...il.com>
> > > > > > > > Signed-off-by: Felipe Balbi <balbi@...com>
> > > > > > > > ---
> > > > > > > 
> > > > > > > Your patches cause that kernel does not print any
> > > > > > > error message to n900 screen anymore and reboot
> > > > > > > device in 10 seconds. I did not loaded any external
> > > > > > > modules.
> > > > > > 
> > > > > > > In qemu I see this crash in early boot:
> > > > > > alright, so n900's working fine. I'll wait until you
> > > > > > debug qemu a little more, thank you
> > > > > 
> > > > > NO! It does not working, see ^^^^. It break n900
> > > > > totally!
> > > > 
> > > > settle down a bit more. I don't have the HW you have and
> > > > things are working fine on boards I _do_ have, there's not
> > > > much more I can do to help without you doing your
> > > > homework. Debug a bit more and bring more information as
> > > > to what's going on, until then you're on your own.
> > > 
> > > And what more do you need? It crash on my n900 and also in
> > > qemu. I sent you kernel crash dump from qemu which
> > > introduced *your* patches. Before applying your patches
> > > there was no crash in early boot stage.
> > > 
> > > In current state I review all 3 patches as:
> > > 
> > > Rejected-by: Pali Rohár <pali.rohar@...il.com>
> > > [It breaks booting Nokia N900 device]
> > 
> > next step, figure why it's broken. Working just fine here on
> > AM335x which has the same musb IP.
> 
> Why is broken? That is easy. You send 3 patches which broke it.

as I said, working just fine here:

http://hastebin.com/zolunekepo

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)