linux-kernel - Re: [PATCH] media:ic:Remove calls to msleep from the functions,ov7670_s_vflip and ov7670_s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20150203175655.668b51ab@lwn.net>
Date:	Tue, 3 Feb 2015 17:56:55 -0500
From:	Jonathan Corbet <corbet@....net>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	mchehab@....samsung.com, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media:ic:Remove calls to msleep from the
 functions,ov7670_s_vflip and ov7670_s_hflip

On Mon,  2 Feb 2015 23:40:17 -0500
Nicholas Krause <xerofoify@...il.com> wrote:

> Removes the no longer required calls to msleep for the duration of 10 miliseconds
> in the functions,ov7670_s_vflip and ov7670_s_hflip respectfully due to no need
> for a delayed sleep of this duration in either function.

So I'm assuming you have the hardware and have verified that it still
works in the absence of these delays?

No, of course you haven't.  You don't understand why the delays are
there, or why they might have a FIXME comment on them.

Nick, surely you've understood by now that this is not the right place to
be putting your energy?  A FIXME comment almost never indicates an issue
that can be trivially resolved; it indicates something that the developer
who wrote the code didn't see a solution to at the time.  Why do you
think you can resolve those issues without understanding them, without
understanding the hardware, and without testing your work?

But then, others have tried to convey this point to you in the past; no
reason to believe I'll be any more successful.  

Please do not send this patch again.

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/