lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 3 Feb 2015 15:17:16 -0800 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: linux-kernel@...r.kernel.org Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, stable@...r.kernel.org, Liu ShuoX <shuox.liu@...el.com>, "Zhang, Yanmin" <yanmin_zhang@...ux.intel.com>, Colin Cross <ccross@...roid.com>, Kees Cook <keescook@...omium.org>, Andrew Morton <akpm@...ux-foundation.org>, Tony Luck <tony.luck@...el.com>, HuKeping <hukeping@...wei.com> Subject: [PATCH 3.10 34/51] pstore: skip zero size persistent ram buffer in traverse 3.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Liu ShuoX <shuox.liu@...el.com> commit aa9a4a1edfbd3d223af01db833da2f07850bc655 upstream. In ramoops_pstore_read, a valid prz pointer with zero size buffer will break traverse of all persistent ram buffers. The latter buffer might be lost. Signed-off-by: Liu ShuoX <shuox.liu@...el.com> Cc: "Zhang, Yanmin" <yanmin_zhang@...ux.intel.com> Cc: Colin Cross <ccross@...roid.com> Reviewed-by: Kees Cook <keescook@...omium.org> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org> Signed-off-by: Tony Luck <tony.luck@...el.com> Cc: HuKeping <hukeping@...wei.com> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org> --- fs/pstore/ram.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) --- a/fs/pstore/ram.c +++ b/fs/pstore/ram.c @@ -126,12 +126,12 @@ ramoops_get_next_prz(struct persistent_r prz = przs[i]; - if (update) { - /* Update old/shadowed buffer. */ + /* Update old/shadowed buffer. */ + if (update) persistent_ram_save_old(prz); - if (!persistent_ram_old_size(prz)) - return NULL; - } + + if (!persistent_ram_old_size(prz)) + return NULL; *typep = type; *id = i; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists