linux-kernel - Re: [PATCH -next] ARC: Fix earlycon build breakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 4 Feb 2015 05:15:59 +0000
From:	Vineet Gupta <Vineet.Gupta1@...opsys.com>
To:	Peter Hurley <peter@...leysoftware.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Stephen Rothwell" <sfr@...b.auug.org.au>,
	Vineet Gupta <Vineet.Gupta1@...opsys.com>,
	Guenter Roeck <linux@...ck-us.net>
Subject: Re: [PATCH -next] ARC: Fix earlycon build breakage

On Wednesday 04 February 2015 06:39 AM, Peter Hurley wrote:
> Commit ffb7fcd66f14 ("ARC: Dynamically determine BASE_BAUD from DeviceTree")
> breaks arc:defconfig build:
>
>        drivers/built-in.o: In function `of_setup_earlycon':
>        (.init.text+0xb3e): undefined reference to `arc_early_base_baud'
>        drivers/built-in.o: In function `setup_earlycon':
>        (.init.text+0xcd0): undefined reference to `arc_early_base_baud'
>        make: *** [vmlinux] Error 1
>
> BASE_BAUD is only required for earlycon, which should depend on
> CONFIG_SERIAL_EARLYCON.
>
> Reported-by: Guenter Roeck <linux@...ck-us.net>
> Tested-by: Guenter Roeck <linux@...ck-us.net>
> Signed-off-by: Peter Hurley <peter@...leysoftware.com>

/Me slaps myself  :-(
Thx for the quick fix Peter. Now applied to my for-next and also quickly tested on
simulator.

FWIW, the issue came about because defconfig doesn't use the 8250 uart driver,
rather the legacy arc uart which still uses earlycon - but I still can't fathom
why i didn't see it earlier.

Thx,
-Vineet

> ---
>  arch/arc/kernel/devtree.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arc/kernel/devtree.c b/arch/arc/kernel/devtree.c
> index 5036d4c..e32b54a 100644
> --- a/arch/arc/kernel/devtree.c
> +++ b/arch/arc/kernel/devtree.c
> @@ -17,7 +17,7 @@
>  #include <asm/clk.h>
>  #include <asm/mach_desc.h>
>  
> -#ifdef CONFIG_SERIAL_8250_CONSOLE
> +#ifdef CONFIG_SERIAL_EARLYCON
>  
>  static unsigned int __initdata arc_base_baud;
>  

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/