linux-kernel - Re: [PATCH] x86/raid6: correctly check for assembler capabilities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <54D1DDAD020000780005CA8E@mail.emea.novell.com>
Date:	Wed, 04 Feb 2015 07:51:57 +0000
From:	"Jan Beulich" <JBeulich@...e.com>
To:	"Paul Bolle" <pebolle@...cali.nl>
Cc:	<mingo@...e.hu>, "Valentin Rothberg" <valentinrothberg@...il.com>,
	<tglx@...utronix.de>, <james.t.kukunas@...ux.intel.com>,
	"NeilBrown" <neilb@...e.de>, <linux-kernel@...r.kernel.org>,
	<hpa@...or.com>
Subject: Re: [PATCH] x86/raid6: correctly check for assembler
 capabilities

>>> On 03.02.15 at 22:03, <pebolle@...cali.nl> wrote:
> On Wed, 2015-02-04 at 07:50 +1100, NeilBrown wrote:
>> Actually the prefix of this macro is "CONFIG_AS_", not "CONFIG_" :-)
>> CONFIG_AS_ is reserved for assembly magic, and is never used by the the
>> kconfig system.
>> 
>> (Well..... I might have made bits of that up, but "git grep 'config AS_'"
>> doesn't find anything).
> 
> That's correct, there are no Kconfig symbols starting with AS_. But
> still, I would like to hear whether there's a reasonable chance I might
> convince other people to adopt my peeve.
> 
> The thinking behind that peeve is, basically, that where people
> encounter a CONFIG_* macro they should only have to check the .config
> file to see how that macro was evaluated in the build that was used.

I too found it curious that CONFIG_* is being used here instead of
e.g. HAVE_*, but with the patch at hand I simply followed suit (as
that normally is the route involving less discussions in order to get
a necessary/desirable fix accepted). In the end I guess you'd need
to convince the x86 maintainers.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/